Fix bug in private pension income uprating (#1199)

* Versioning

* Fix issue

Author: nikhilwoodruff

changelog_entry.yaml

@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - Bug in private pension income uprating.

policyengine_uk/data/uprating_growth_factors.csv

@@ -58,7 +58,7 @@ personal_pension_contributions,gov.obr.per_capita.employment_income,0,0.072,0.07
 petrol_spending,gov.obr.consumer_price_index,0,0.039,0.101,0.057,0.023,0.032,0.02,0.02,0.02,0.02
 pip_dl_reported,gov.obr.consumer_price_index,0,0.039,0.101,0.057,0.023,0.032,0.02,0.02,0.02,0.02
 pip_m_reported,gov.obr.consumer_price_index,0,0.039,0.101,0.057,0.023,0.032,0.02,0.02,0.02,0.02
-private_pension_income,gov.obr.private_pension_index,0,0.05,0.05,0.033,0.041,0.031,0.029,0.029,0.028,0.0
+private_pension_income,gov.obr.per_capita.non_labour_income,0,0.068,0.134,0.052,0.069,0.057,0.049,0.038,0.029,0.03
 private_transfer_income,gov.obr.per_capita.gdp,0,0.125,0.092,0.05,0.038,0.028,0.028,0.031,0.033,0.033
 property_income,gov.obr.per_capita.gdp,0,0.125,0.092,0.05,0.038,0.028,0.028,0.031,0.033,0.033
 recreation_consumption,gov.obr.consumer_price_index,0,0.039,0.101,0.057,0.023,0.032,0.02,0.02,0.02,0.02

policyengine_uk/parameters/gov/contrib/create_private_pension_uprating.py

@@ -3,7 +3,7 @@
     Parameter,
 )
 
-YEARS = list(range(2009, 2035))
+YEARS = list(range(2010, 2035))
 
 
 def add_private_pension_uprating_factor(
@@ -13,8 +13,8 @@ def add_private_pension_uprating_factor(
     rpi = parameters.gov.obr.rpi
     last_value = rpi(2008)
     for year in YEARS:
-        value = rpi(year)
-        rel_change = value / rpi(year - 1)
+        value = rpi(year - 1)
+        rel_change = value / rpi(year - 2)
         rel_change = min(rel_change, 1.05)
         new_index = last_value * rel_change
         last_value = new_index

policyengine_uk/variables/gov/dfe/free_school_fruit_veg.py

@@ -7,3 +7,4 @@ class free_school_fruit_veg(Variable):
     definition_period = YEAR
     value_type = float
     unit = GBP
+    uprating = "gov.obr.consumer_price_index"

policyengine_uk/variables/gov/dfe/free_school_meals.py

@@ -7,3 +7,4 @@ class free_school_meals(Variable):
     definition_period = YEAR
     value_type = float
     unit = GBP
+    uprating = "gov.obr.consumer_price_index"

policyengine_uk/variables/input/private_pension_income.py

@@ -10,4 +10,4 @@ class private_pension_income(Variable):
     unit = GBP
     reference = "Income Tax (Earnings and Pensions) Act 2003 s. 1(1)(b)"
     quantity_type = FLOW
-    uprating = "gov.obr.private_pension_index"
+    uprating = "gov.obr.per_capita.non_labour_income"