Skip to content

Commit ccfea58

Browse files
BRMA variable is uppercase (#1151)
* BRMA variable is uppercase Fixes #1150 * Fix tests * Fix final test
1 parent b7c2e38 commit ccfea58

6 files changed

Lines changed: 13 additions & 9 deletions

File tree

changelog_entry.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- bump: patch
2+
changes:
3+
fixed:
4+
- Bug with BRMA variable name.

policyengine_uk/system.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class CountryTaxBenefitSystem(TaxBenefitSystem):
4646
variables_dir = COUNTRY_DIR / "variables"
4747
auto_carry_over_input_variables = True
4848
basic_inputs = [
49-
"BRMA",
49+
"brma",
5050
"local_authority",
5151
"region",
5252
"employment_income",

policyengine_uk/tests/policy/baseline/finance/benefit/family/LHA.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@
55
age: 18
66
LHA_category: C
77
output:
8-
BRMA: MAIDSTONE
8+
brma: MAIDSTONE
99
BRMA_LHA_rate: 9_771
1010
- name: BRMA inputs
1111
period: 2020
1212
absolute_error_margin: 0
1313
input:
14-
BRMA: GUILDFORD
14+
brma: GUILDFORD
1515
output:
16-
BRMA: GUILDFORD
16+
brma: GUILDFORD
1717
- name: BRMA and category
1818
period: 2020
1919
absolute_error_margin: 20
2020
input:
21-
BRMA: GUILDFORD
21+
brma: GUILDFORD
2222
LHA_category: C
2323
output:
24-
BRMA: GUILDFORD
24+
brma: GUILDFORD
2525
LHA_category: C
2626
BRMA_LHA_rate: 13_164

policyengine_uk/tests/policy/baseline/gov/abolitions/abolition_parameters.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
household:
9898
members: [claimant]
9999
rent: 500
100-
BRMA: "CENTRAL_LONDON"
100+
brma: "CENTRAL_LONDON"
101101
tenure_type: "RENT_PRIVATELY"
102102
output:
103103
housing_benefit: 0

policyengine_uk/variables/gov/dwp/BRMA_LHA_rate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class BRMA_LHA_rate(Variable):
2020

2121
def formula(benunit, period, parameters):
2222
brma = benunit.value_from_first_person(
23-
benunit.members.household("BRMA", period).decode_to_str()
23+
benunit.members.household("brma", period).decode_to_str()
2424
)
2525
category = benunit("LHA_category", period).decode_to_str()
2626

policyengine_uk/variables/household/BRMA.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import numpy as np
66

77

8-
class BRMA(Variable):
8+
class brma(Variable):
99
value_type = Enum
1010
possible_values = BRMAName
1111
default_value = BRMAName.MAIDSTONE

0 commit comments

Comments
 (0)