Skip to content

BRMA variable is uppercase #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilwoodruff merged 3 commits into from
Jun 12, 2025
Merged

BRMA variable is uppercase #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9717663
BRMA variable is uppercase
nikhilwoodruff Jun 12, 2025
53059a9
Fix tests
nikhilwoodruff Jun 12, 2025
d727dc1
Fix final test
nikhilwoodruff Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
fixed:
- Bug with BRMA variable name.
2 changes: 1 addition & 1 deletion policyengine_uk/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class CountryTaxBenefitSystem(TaxBenefitSystem):
variables_dir = COUNTRY_DIR / "variables"
auto_carry_over_input_variables = True
basic_inputs = [
"BRMA",
"brma",
"local_authority",
"region",
"employment_income",
Expand Down
10 changes: 5 additions & 5 deletions policyengine_uk/tests/policy/baseline/finance/benefit/family/LHA.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@
age: 18
LHA_category: C
output:
BRMA: MAIDSTONE
brma: MAIDSTONE
BRMA_LHA_rate: 9_771
- name: BRMA inputs
period: 2020
absolute_error_margin: 0
input:
BRMA: GUILDFORD
brma: GUILDFORD
output:
BRMA: GUILDFORD
brma: GUILDFORD
- name: BRMA and category
period: 2020
absolute_error_margin: 20
input:
BRMA: GUILDFORD
brma: GUILDFORD
LHA_category: C
output:
BRMA: GUILDFORD
brma: GUILDFORD
LHA_category: C
BRMA_LHA_rate: 13_164
2 changes: 1 addition & 1 deletion policyengine_uk/tests/policy/baseline/gov/abolitions/abolition_parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
household:
members: [claimant]
rent: 500
BRMA: "CENTRAL_LONDON"
brma: "CENTRAL_LONDON"
tenure_type: "RENT_PRIVATELY"
output:
housing_benefit: 0
Expand Down
2 changes: 1 addition & 1 deletion policyengine_uk/variables/gov/dwp/BRMA_LHA_rate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class BRMA_LHA_rate(Variable):

def formula(benunit, period, parameters):
brma = benunit.value_from_first_person(
benunit.members.household("BRMA", period).decode_to_str()
benunit.members.household("brma", period).decode_to_str()
)
category = benunit("LHA_category", period).decode_to_str()

Expand Down
2 changes: 1 addition & 1 deletion policyengine_uk/variables/household/BRMA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import numpy as np


class BRMA(Variable):
class brma(Variable):
value_type = Enum
possible_values = BRMAName
default_value = BRMAName.MAIDSTONE
Expand Down
Loading