Fix parameter uprating bug#1223
Closed
vahid-ahmadi wants to merge 8 commits into
Closed
Conversation
nikhilwoodruff
requested changes
Jul 14, 2025
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking a look. Could you add a test for this? We can reinstate the ubuntu-latest runner, if you add it it should pass/fail on the same tests.
Collaborator
Author
Thanks! Added. |
Collaborator
|
unless you want to keep this @vahid-ahmadi , ok if I close it? not actually sure that the proxy object works, and I think it adds a lot of bloat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209