From b5a59be8d29cb9788a1f71bc9fe75c1bf7f3cac6 Mon Sep 17 00:00:00 2001 From: Nikhil Woodruff Date: Thu, 17 Jul 2025 13:07:27 +0100 Subject: [PATCH 1/4] Don't attempt to simulate domestic rates Fixes #1247 --- changelog_entry.yaml | 4 ++++ .../gov/economic_assumptions/yoy_growth.yaml | 17 +++++++++++++++++ .../gov/local_authorities/domestic_rates.py | 14 -------------- 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/changelog_entry.yaml b/changelog_entry.yaml index e69de29bb..50564d496 100644 --- a/changelog_entry.yaml +++ b/changelog_entry.yaml @@ -0,0 +1,4 @@ +- bump: patch + changes: + fixed: + - NI domestic rates taken as reported. diff --git a/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml b/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml index f851ff3ba..a36db8381 100644 --- a/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml +++ b/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml @@ -310,3 +310,20 @@ ofwat: href: https://www.ofwat.gov.uk/price-review/ - title: Ofwat 2025-26 media statement href: https://www.ofwat.gov.uk/average-bills-2025-26-press-statement/ +finance_ni: + domestic_rates: + description: Domestic rates year-on-year growth. + values: + 2024-01-01: 0.050 + 2025-01-01: 0.047 + 2026-01-01: 0.05 + 2027-01-01: 0.05 + 2028-01-01: 0.05 + 2029-01-01: 0.05 + 2020-01-01: 0.05 + metadata: + unit: /1 + label: domestic rates growth + reference: + - title: Finance NI (based on outturn) + href: https://www.finance-ni.gov.uk/ \ No newline at end of file diff --git a/policyengine_uk/variables/gov/local_authorities/domestic_rates.py b/policyengine_uk/variables/gov/local_authorities/domestic_rates.py index 4819fd4e5..32536bb5b 100644 --- a/policyengine_uk/variables/gov/local_authorities/domestic_rates.py +++ b/policyengine_uk/variables/gov/local_authorities/domestic_rates.py @@ -7,17 +7,3 @@ class domestic_rates(Variable): definition_period = YEAR value_type = float unit = GBP - - def formula(household, period, parameters): - rates = parameters(period).gov.local_authorities.domestic_rates.rates - local_authority = household("local_authority", period) - rate_defined = pd.Series(local_authority.decode_to_str()).isin( - rates._children - ) - percent = np.zeros(household.count, dtype=float) - if any(rate_defined): - percent[rate_defined] = rates[local_authority[rate_defined]] - main_residence_value = household("main_residence_value", period) - return percent * main_residence_value - else: - return 0 From 62966caab91ae36461a74d57548fd2951324f8a4 Mon Sep 17 00:00:00 2001 From: Nikhil Woodruff Date: Thu, 17 Jul 2025 13:16:06 +0100 Subject: [PATCH 2/4] Assume 0% domestic rates growth --- .../gov/economic_assumptions/yoy_growth.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml b/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml index a36db8381..1e89fd51a 100644 --- a/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml +++ b/policyengine_uk/parameters/gov/economic_assumptions/yoy_growth.yaml @@ -316,11 +316,11 @@ finance_ni: values: 2024-01-01: 0.050 2025-01-01: 0.047 - 2026-01-01: 0.05 - 2027-01-01: 0.05 - 2028-01-01: 0.05 - 2029-01-01: 0.05 - 2020-01-01: 0.05 + 2026-01-01: 0.0 + 2027-01-01: 0.0 + 2028-01-01: 0.0 + 2029-01-01: 0.0 + 2020-01-01: 0.0 metadata: unit: /1 label: domestic rates growth From 4897d9e43ab716f912f042e357d5fbcd107e3ce3 Mon Sep 17 00:00:00 2001 From: Nikhil Woodruff Date: Thu, 17 Jul 2025 13:18:25 +0100 Subject: [PATCH 3/4] Remove old test --- .../baseline/gov/local_authorities/domestic_rates.yaml | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 policyengine_uk/tests/policy/baseline/gov/local_authorities/domestic_rates.yaml diff --git a/policyengine_uk/tests/policy/baseline/gov/local_authorities/domestic_rates.yaml b/policyengine_uk/tests/policy/baseline/gov/local_authorities/domestic_rates.yaml deleted file mode 100644 index 10de87b25..000000000 --- a/policyengine_uk/tests/policy/baseline/gov/local_authorities/domestic_rates.yaml +++ /dev/null @@ -1,7 +0,0 @@ -- name: Domestic rates example 1 - period: 2022 - input: - local_authority: BELFAST - main_residence_value: 300_000 - output: - domestic_rates: 2_440.80 \ No newline at end of file From cf022c524fc819b6171db8a15ee4c6eacd1ac628 Mon Sep 17 00:00:00 2001 From: Nikhil Woodruff Date: Thu, 17 Jul 2025 13:37:00 +0100 Subject: [PATCH 4/4] Update tests --- policyengine_uk/tests/microsimulation/reforms_config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/policyengine_uk/tests/microsimulation/reforms_config.yaml b/policyengine_uk/tests/microsimulation/reforms_config.yaml index df97fd3a2..b6be6b317 100644 --- a/policyengine_uk/tests/microsimulation/reforms_config.yaml +++ b/policyengine_uk/tests/microsimulation/reforms_config.yaml @@ -16,7 +16,7 @@ reforms: parameters: gov.hmrc.child_benefit.amount.additional: 25 - name: Reduce Universal Credit taper rate to 20% - expected_impact: -37.7 + expected_impact: -36.5 parameters: gov.dwp.universal_credit.means_test.reduction_rate: 0.2 - name: Raise Class 1 main employee NICs rate to 10% @@ -24,7 +24,7 @@ reforms: parameters: gov.hmrc.national_insurance.class_1.rates.employee.main: 0.1 - name: Raise VAT standard rate by 2pp - expected_impact: 19.4 + expected_impact: 18.8 parameters: gov.hmrc.vat.standard_rate: 0.22 - name: Raise additional rate by 3pp