Expand National Insurance documentation page (#746)#1699
Open
vahid-ahmadi wants to merge 1 commit into
Open
Conversation
The existing page covered Classes 1, 2 and 4 and ended in two parameter
charts. Round it out with:
- Class 3 (voluntary) added to the modelling table now that ni_class_3
is exposed,
- a "How PolicyEngine computes National Insurance liability" section that
walks through the per-class variables and the household total,
- a References block (SSCBA 1992, HMRC rates page, HMRC outturn stats).
Also fix the chained boolean indexing in the rates chart cell, which was
triggering a pandas UserWarning ("Boolean Series key will be reindexed").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ni_class_3.ni_class_1_employee,ni_class_1_employer,ni_class_2,ni_class_3,ni_class_4) and explains how they roll up intonational_insuranceand government revenue.df[df[\"Threshold\"] == False][df.Value < 1], which produced a pandas "Boolean Series key will be reindexed" UserWarning in the rendered output. Combined into a single boolean mask.Test plan
🤖 Generated with Claude Code