Split childcare_entitlements umbrella into per-programme registry rows (#1644)#1703
Open
vahid-ahmadi wants to merge 1 commit into
Open
Split childcare_entitlements umbrella into per-programme registry rows (#1644)#1703vahid-ahmadi wants to merge 1 commit into
vahid-ahmadi wants to merge 1 commit into
Conversation
#1644 structural finding #1: programs.yaml had an umbrella childcare_entitlements entry with no `variable` or `parameter_prefix` field, leaving it orphan in the model-coverage page. The repo has three distinct entitlement variables and parameter trees (universal_childcare_entitlement, extended_childcare_entitlement, targeted_childcare_entitlement), so split the umbrella into three rows, each bound to its variable and parameter prefix. Other audit items (UK-wide coverage gaps, Scotland/Wales/NI programmes, the weeks_per_year regionalisation) remain open and will be handled in separate PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
childcare_entitlementsentry inprograms.yamllacked bothvariableandparameter_prefix, leaving it orphan on the model-coverage page.universal_childcare_entitlement(15h),extended_childcare_entitlement(30h working parents), andtargeted_childcare_entitlement(disadvantaged 2yo + working families).gov.dfe.<name>prefix. Notes preserved/refined from the original entry.The remaining items in #1644 (UK-wide coverage gaps, Scotland/Wales/NI programmes, regionalising
weeks_per_yearandchildcare_funding_rate) stay open and will be handled in separate PRs.Test plan
yaml.safe_load(programs.yaml)succeeds;childcare_entitlementsis gone and the three new ids are present.variableandparameter_prefixpopulated.🤖 Generated with Claude Code