Seed EntitledTo-style integration tests (#778)#1713
Open
vahid-ahmadi wants to merge 1 commit into
Open
Conversation
#778 asks for ~20 worked benefit scenarios checked against EntitledTo. This is a first batch of three covering the most common household shapes the calculator handles: 1. single 30-year-old working part-time on low pay, private renter in London (UC + child benefit zero, no income tax/NI), 2. couple with two children, one earner at £22k, social housing in North West (UC + child benefit, partial NI/income tax), 3. pensioner couple with low state pension, sits below Pension Credit guarantee level (PC payout + winter fuel allowance). Values are pinned to the current PolicyEngine output and the file is labelled as a regression-grade baseline rather than an authoritative EntitledTo cross-validation — future work is to manually re-run the matching cases through EntitledTo and tighten any rows where the two disagree, ratcheting up to the ~20-scenario coverage in the issue. Person-level variables (income_tax, national_insurance) can't be asserted with a single scalar when multiple people are in the benunit, so scenario 2 uses household_tax instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine_uk/tests/policy/integration/entitledto_scenarios.yamlwith three common household shapes:household_tax).income_tax,national_insurance) can't be asserted with a single scalar across a multi-person benunit, so scenario 2 useshousehold_tax(the aggregate that already includes both).Test plan
policyengine-core test policyengine_uk/tests/policy/integration/entitledto_scenarios.yaml -c policyengine_uk(3 passed).🤖 Generated with Claude Code