Add fiscal-year uprating planning docs page (#1437 #1436)#1716
Open
vahid-ahmadi wants to merge 1 commit into
Open
Add fiscal-year uprating planning docs page (#1437 #1436)#1716vahid-ahmadi wants to merge 1 commit into
vahid-ahmadi wants to merge 1 commit into
Conversation
#1437 is filed as a low-priority enhancement to align uprating indices with the UK fiscal year (April 6) rather than the current January 1 dates plus convert_to_fiscal_year_parameters post-process workaround. #1436 proposes the inverse — keep January 1 dates but resolve the conversion lazily at query time. This page captures both, the relationship between them, and the recommended sequencing (#1437 first, then re-evaluate #1436). It also identifies the four pipeline changes the April-date move needs: 1. yoy_growth.yaml dates from YYYY-01-01 to YYYY-04-06, 2. create_economic_assumption_indices.py emitting at April 6, 3. confirm policyengine-core's uprate_parameters doesn't hardcode January 1, 4. remove convert_to_fiscal_year_parameters and its call site in tax_benefit_system.py. The headline correctness gain is that mid-year queries (e.g. param("2026-05-15")) currently return the wrong fiscal-year value, and the planned change fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_to_fiscal_year_parameterspost-process workaround. Explore on-the-fly fiscal year parameter conversion #1436 proposes the inverse — keep January 1 dates but resolve the conversion lazily at query time.docs/book/assumptions/fiscal-year-uprating-plan.md, with the relationship between them, the four pipeline changes the April-date move requires, and a recommended sequencing (Use April dates for uprating indices to align with UK fiscal year #1437 first, then re-evaluate Explore on-the-fly fiscal year parameter conversion #1436 onceconvert_to_fiscal_year_parametersis gone).param(\"2026-05-15\")) today return the wrong fiscal-year value because of where the January 1 date sits relative to April 6; the planned change fixes that.Test plan
assumptions/.🤖 Generated with Claude Code