Add UK pipeline alignment planning doc (#1621)#1723
Open
vahid-ahmadi wants to merge 1 commit into
Open
Conversation
#1621 is an umbrella tracker. Persist it in-repo as a docs page so the queue of architectural fixes has a stable reference. Auditing the current state: - The three small bugs flagged in the issue body (tax_credits min_benefit unit, benunit_weekly_hours label, state_pension_type heuristic) have all been fixed since the issue was filed. Note them as done. - The state pension residual is documented separately in #1632 (now covered by docs/book/programs/gov/dwp/state-pension.md), so this page links there rather than restating. The remaining architectural gaps captured: - runtime _reported consultation in would_claim_housing_benefit, would_claim_IS, would_claim_WTC, would_claim_CTC — needs conversion to input-only matching the UC/PC pattern, with stochastic assignment in policyengine-uk-data; - take-up assignment in uk-data ignores reported data — needs port of the US assign_takeup_with_reported_anchors helper; - second-stage QRF gap on SPI donors (analogous to policyengine-us-data#589) so consequential FRS-only variables (rent, gift_aid, pension contributions, *_reported benefits) are consistent with imputed income; - residual aggregate gaps against OBR (income_support, esa_contrib, attendance_allowance, tax_free_childcare, state_pension). Ends with a candidate PR sequence so the receiving repos (this one + policyengine-uk-data) have a low-risk-first ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/book/assumptions/uk-pipeline-alignment-plan.md.Key findings from auditing the issue body against the current code:
tax_credits/min_benefit.yamlunit is nowcurrency-GBP(was USD).benunit_weekly_hourslabel now reads "Total weekly hours" (matches theadds = [\"weekly_hours\"]sum behaviour).state_pension_typeBASIC/NEW classification was rewritten in PR Fix state_pension_type classifying all pensioners as BASIC #1618.state-pension.md, so this page just links there.The page captures the remaining architectural gaps:
_reportedconsultation inwould_claim_housing_benefit/_IS/_WTC/_CTC— needs conversion to input-only matching the UC/PC pattern, with stochastic assignment inpolicyengine-uk-data.policyengine-uk-dataignores reported data — needs port of the USassign_takeup_with_reported_anchorshelper.policyengine-us-data#589) so consequential FRS-only variables (rent,gift_aid, pension contributions,*_reportedbenefits) come out consistent with imputed income.Plus residual aggregate gaps against OBR (
income_support,esa_contrib,attendance_allowance,tax_free_childcare) and a candidate PR sequence with the safest item first.Test plan
assumptions/.🤖 Generated with Claude Code