Add capital gains distribution planning doc (#818 #817)#1731
Open
vahid-ahmadi wants to merge 1 commit into
Open
Add capital gains distribution planning doc (#818 #817)#1731vahid-ahmadi wants to merge 1 commit into
vahid-ahmadi wants to merge 1 commit into
Conversation
#818 asks for a multivariate capital gains imputation instead of the current per-income-decile-independent fits. #817 reports the related failure mode of imputing gains to zero-wealth households. The imputation lives in policyengine-uk-data, not in this repo, but persist the model-facing plan here so the cross-repo agreement is discoverable. The page covers: - the current state (per-decile marginal distributions fit to HMRC CGT statistics binned by income), - three concrete limitations (overfitting boundaries, no wealth conditioning per #817, no within-decile correlation), - two candidate approaches: A. multivariate Gaussian KDE following OG-USA's bequest-transmission model; B. two-stage QRF reusing the existing imputation infrastructure already proposed in the #1621 pipeline-alignment plan, - recommendation: B (QRF) because the infrastructure exists, it handles correlated predictors naturally, and it solves both #818 and #817 in one move by adding total_wealth as a predictor, - the model-side surface (negligible, since the input variable stays the same; one new regression test for "no gains on zero-wealth households"), - open questions on the wealth donor source (FRS vs WAS) and on elasticity-by-band as a follow-up. Closes both #818 and #817 in the planning sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine-uk-data, but persist the model-facing plan in-repo atdocs/book/assumptions/capital-gains-distribution-plan.mdso the cross-repo agreement is discoverable from one place.total_wealthas a predictor solves both Model capital gains distribution considering all income groups together #818 (overfitting) and Avoid imputing capital gains to households with zero wealth #817 (zero-wealth gains) in one move;capital_gains_before_responseinput stays the same; one new regression test ("no positive gains on zero-wealth households") lives well inpolicyengine_uk/tests/;Closes both #818 and #817 in the planning sense (the data-side implementation is the actual work).
Test plan
assumptions/.🤖 Generated with Claude Code