Skip to content

Commit 32e5213

Browse files
authored
Merge pull request #749 from PolicyEngine/codex/h5-migration-pr2-typed-request-construction
Add typed local H5 request construction
2 parents 0f684c0 + f848260 commit 32e5213

20 files changed

Lines changed: 1488 additions & 182 deletions

.github/workflows/pipeline.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
with:
5252
python-version: "3.14"
5353

54-
- name: Install Modal
55-
run: pip install modal
54+
- name: Install Modal Runner Deps
55+
run: pip install modal pandas
5656

5757
- name: Deploy and launch pipeline on Modal
5858
env:

changelog.d/749.changed.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Introduced typed local H5 request construction with `AreaBuildRequest`,
2+
`AreaFilter`, and `USAreaCatalog`, while keeping the worker's legacy
3+
`--work-items` path available for backward compatibility.

modal_app/local_area.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,12 @@ def validate_staging(branch: str, run_id: str, version: str = "") -> Dict:
553553
if not version:
554554
version = run_id.split("_", 1)[0]
555555

556+
# PR 9 migration note:
557+
# The coordinator still enumerates states, districts, and cities inline
558+
# and emits legacy work_items. This is intentionally temporary for the
559+
# dual-path migration. The target cleanup is to delegate regional request
560+
# enumeration to USAreaCatalog and send typed --requests-json payloads to
561+
# workers so area construction no longer lives in the coordinator.
556562
result = subprocess.run(
557563
[
558564
"uv",

modal_app/pipeline.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,7 @@ def _write_validation_diagnostics(
489489
csv_columns = [
490490
"area_type",
491491
"area_id",
492+
"display_name",
492493
"district",
493494
"variable",
494495
"target_name",

0 commit comments

Comments
 (0)