Skip to content

Commit 6a959a4

Browse files
anth-volkclaude
andcommitted
Fix pre-existing test failures from main
- Remove test_reproducibility.py: imports modules that never existed (enhanced_cps.imputation, enhanced_cps.reweight, scripts). Broken since PR #117 (July 2025), never caught because old testpaths didn't include top-level tests/. - Fix test_legacy_target_overview_without_reform_id: create builder before installing legacy view so __init__'s create_or_replace_views doesn't overwrite it. Clear column cache so builder re-detects missing reform_id. Mirrors fix from unmerged PR #665. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8ad8170 commit 6a959a4

2 files changed

Lines changed: 2 additions & 273 deletions

File tree

policyengine_us_data/tests/unit/calibration/test_unified_matrix_builder.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,10 @@ def test_inactive_targets_are_excluded(self):
275275
self.assertEqual(float(baseline_rows.iloc[0]["value"]), 10000.0)
276276

277277
def test_legacy_target_overview_without_reform_id(self):
278+
b = self._make_builder()
278279
_create_legacy_target_overview(self.engine)
280+
b._target_overview_columns = None
279281
try:
280-
b = self._make_builder()
281282
df = b._query_targets({"domain_variables": ["aca_ptc"]})
282283
self.assertGreater(len(df), 0)
283284
self.assertIn("reform_id", df.columns)

policyengine_us_data/tests/unit/test_reproducibility.py

Lines changed: 0 additions & 272 deletions
This file was deleted.

0 commit comments

Comments
 (0)