Format structural mortgage support files

Author: MaxGhenis

policyengine_us_data/datasets/puf/puf.py

@@ -646,7 +646,10 @@ def generate(self):
                 self.holder[key] = np.array(self.holder[key]).astype(float)
                 assert not np.isnan(self.holder[key]).any(), f"{key} has NaNs."
 
-        holder_tp = {variable: {self.time_period: values} for variable, values in self.holder.items()}
+        holder_tp = {
+            variable: {self.time_period: values}
+            for variable, values in self.holder.items()
+        }
         holder_tp = convert_mortgage_interest_to_structural_inputs(
             holder_tp,
             self.time_period,

policyengine_us_data/tests/test_calibration/test_mortgage_interest.py

@@ -117,12 +117,8 @@ def test_structural_mortgage_conversion_keeps_balance_hints_for_non_itemizers():
 
     converted = convert_mortgage_interest_to_structural_inputs(data, 2024)
 
-    assert converted["first_home_mortgage_balance"][2024][0] == pytest.approx(
-        250_000.0
-    )
-    assert converted["second_home_mortgage_balance"][2024][0] == pytest.approx(
-        25_000.0
-    )
+    assert converted["first_home_mortgage_balance"][2024][0] == pytest.approx(250_000.0)
+    assert converted["second_home_mortgage_balance"][2024][0] == pytest.approx(25_000.0)
     assert converted["first_home_mortgage_interest"][2024][0] == 0
     assert converted["second_home_mortgage_interest"][2024][0] == 0
     assert converted["first_home_mortgage_origination_year"][2024][0] > 0

policyengine_us_data/utils/mortgage_interest.py

@@ -327,7 +327,9 @@ def _build_tax_unit_mortgage_receiver(
     person_tax_unit_ids = np.asarray(person_tax_unit_ids)
     is_head = np.asarray(is_head, dtype=bool)
     n_tax_units = len(tax_unit_ids)
-    tax_unit_index = {int(tax_unit_id): idx for idx, tax_unit_id in enumerate(tax_unit_ids)}
+    tax_unit_index = {
+        int(tax_unit_id): idx for idx, tax_unit_id in enumerate(tax_unit_ids)
+    }
     person_tax_unit_idx = np.array(
         [tax_unit_index[int(tax_unit_id)] for tax_unit_id in person_tax_unit_ids],
         dtype=np.int32,
@@ -418,13 +420,9 @@ def _build_scf_mortgage_donor(scf: pd.DataFrame) -> pd.DataFrame:
     donor["is_female"] = _frame_column(scf, "is_female")
     donor["cps_race"] = _frame_column(scf, "cps_race")
     donor["is_married"] = _frame_column(scf, "is_married")
-    donor["own_children_in_household"] = _frame_column(
-        scf, "own_children_in_household"
-    )
+    donor["own_children_in_household"] = _frame_column(scf, "own_children_in_household")
     donor["employment_income"] = _frame_column(scf, "employment_income")
-    donor["interest_dividend_income"] = _frame_column(
-        scf, "interest_dividend_income"
-    )
+    donor["interest_dividend_income"] = _frame_column(scf, "interest_dividend_income")
     donor["social_security_pension_income"] = _frame_column(
         scf, "social_security_pension_income"
     )
@@ -527,7 +525,11 @@ def _tax_unit_mortgage_owner_status(
     spm_tenure = data.get("spm_unit_tenure_type", {}).get(time_period)
     person_spm_unit_id = data.get("person_spm_unit_id", {}).get(time_period)
     spm_unit_ids = data.get("spm_unit_id", {}).get(time_period)
-    if spm_tenure is not None and person_spm_unit_id is not None and spm_unit_ids is not None:
+    if (
+        spm_tenure is not None
+        and person_spm_unit_id is not None
+        and spm_unit_ids is not None
+    ):
         spm_map = {
             int(spm_unit_id): _decode_owner_status(value)
             for spm_unit_id, value in zip(spm_unit_ids, spm_tenure)
@@ -723,9 +725,13 @@ def _split_interest_by_balance(
 
     with_second = total_balance > 0
     first_interest[with_second] = (
-        total_interest[with_second] * first_balance[with_second] / total_balance[with_second]
+        total_interest[with_second]
+        * first_balance[with_second]
+        / total_balance[with_second]
+    )
+    second_interest[with_second] = (
+        total_interest[with_second] - first_interest[with_second]
     )
-    second_interest[with_second] = total_interest[with_second] - first_interest[with_second]
 
     no_second = second_balance == 0
     first_interest[no_second] = total_interest[no_second]