Skip to content

Commit a09b736

Browse files
baogorekclaude
andcommitted
Restore push trigger on pipeline, remove approval gate and timeouts
- pipeline.yaml triggers on push to main again (promote is the only manual gate, not the pipeline itself) - Remove approval-gate and trigger-pipeline jobs from push.yaml - Remove timeout-minutes (defaults to 6h) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9b7c18c commit a09b736

3 files changed

Lines changed: 3 additions & 29 deletions

File tree

.github/workflows/pipeline.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Run Pipeline
22

33
on:
4+
push:
5+
branches: [main]
46
workflow_dispatch:
57
inputs:
68
gpu:
@@ -27,7 +29,6 @@ on:
2729
jobs:
2830
pipeline:
2931
runs-on: ubuntu-latest
30-
timeout-minutes: 30
3132
steps:
3233
- uses: actions/checkout@v4
3334

.github/workflows/push.yaml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ jobs:
1717
runs-on: ubuntu-latest
1818
needs: lint
1919
if: github.event.head_commit.message != 'Update package version'
20-
timeout-minutes: 240
2120
env:
2221
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
2322
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
@@ -34,32 +33,6 @@ jobs:
3433
--upload \
3534
--branch=${{ github.ref_name }}
3635
37-
# ── Manual approval gate ────────────────────────────────────
38-
approval-gate:
39-
needs: build-and-test
40-
runs-on: ubuntu-latest
41-
environment: pipeline-approval
42-
steps:
43-
- run: echo "Pipeline approved. Dispatching H5 build."
44-
45-
# ── Dispatch pipeline ───────────────────────────────────────
46-
trigger-pipeline:
47-
needs: approval-gate
48-
runs-on: ubuntu-latest
49-
steps:
50-
- name: Trigger pipeline workflow
51-
uses: actions/github-script@v7
52-
with:
53-
github-token: ${{ secrets.GITHUB_TOKEN }}
54-
script: |
55-
await github.rest.actions.createWorkflowDispatch({
56-
owner: context.repo.owner,
57-
repo: context.repo.repo,
58-
workflow_id: 'pipeline.yaml',
59-
ref: 'main',
60-
})
61-
console.log('Pipeline dispatched')
62-
6336
# ── Documentation ──────────────────────────────────────────
6437
docs:
6538
runs-on: ubuntu-latest

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Six workflow files in `.github/workflows/`:
5050
- **`pr.yaml`** — Runs on every PR to main: fork check, lint, uv.lock freshness, changelog fragment, unit tests with Codecov, smoke test, and docs build. Integration tests trigger automatically when the PR changes files in `policyengine_us_data/`, `modal_app/`, or `tests/integration/`. ~2-3 minutes for unit tests.
5151
- **`push.yaml`** — Runs on push to main. Two paths:
5252
- Version bump commits (`Update package version`): build and publish to PyPI
53-
- All other commits: full Modal data build with integration tests → manual approval gate → pipeline dispatch
53+
- All other commits: full Modal data build with integration tests
5454
- Docs build and deploy to gh-pages runs unconditionally on every push.
5555
- **`pipeline.yaml`** — Dispatch only. Spawns the H5 generation pipeline on Modal with configurable GPU, epochs, and worker count.
5656
- **`versioning.yaml`** — Auto-bumps version when changelog.d fragments are merged. Commits `Update package version` which triggers the publish path in push.yaml.

0 commit comments

Comments
 (0)