Relax housing assistance validation floor

Author: MaxGhenis

changelog.d/housing-validation-threshold.fixed

@@ -0,0 +1 @@
+Avoid false-positive housing assistance validation failures in publication builds.

policyengine_us_data/datasets/cps/extended_cps.py

@@ -694,7 +694,11 @@ def reconcile_ss_subcomponents(predictions, total_ss):
     "rent",
     "spm_unit_capped_work_childcare_expenses",
 }
-_MIN_MODELED_HOUSING_SHARE_OF_BENCHMARK = 0.50
+# The PE formula reconstruction is a guard against missing housing assistance
+# inputs, not a calibration target for the Census SPM raw housing-subsidy field.
+# Production CPS builds have a roughly 49% formula/raw ratio, so leave margin
+# for that observed gap while still catching clearly broken reconstructions.
+_MIN_MODELED_HOUSING_SHARE_OF_BENCHMARK = 0.45
 
 
 class _InMemoryTimePeriodDataset(Dataset):

tests/unit/test_extended_cps.py

@@ -451,7 +451,7 @@ def test_housing_assistance_validation_allows_observed_formula_gap(self):
 
         assert result is data
 
-    def test_housing_assistance_validation_rejects_half_reported_match(self):
+    def test_housing_assistance_validation_allows_observed_production_gap(self):
         data = {
             "receives_housing_assistance": {2024: np.array([True])},
             "takes_up_housing_assistance_if_eligible": {2024: np.array([True])},
@@ -463,6 +463,26 @@ def test_housing_assistance_validation_rejects_half_reported_match(self):
             "spm_unit_weight": np.array([1.0]),
         }
 
+        result = ExtendedCPS._validate_housing_assistance_microsimulation(
+            data,
+            2024,
+            microsimulation_cls=_FakeHousingMicrosimulation,
+        )
+
+        assert result is data
+
+    def test_housing_assistance_validation_rejects_clear_benchmark_gap(self):
+        data = {
+            "receives_housing_assistance": {2024: np.array([True])},
+            "takes_up_housing_assistance_if_eligible": {2024: np.array([True])},
+            "spm_unit_capped_housing_subsidy": {2024: np.array([100.0])},
+        }
+        _FakeHousingMicrosimulation.outputs = {
+            "housing_assistance": np.array([100.0]),
+            "spm_unit_capped_housing_subsidy": np.array([44.0]),
+            "spm_unit_weight": np.array([1.0]),
+        }
+
         with pytest.raises(RuntimeError, match="implausibly small"):
             ExtendedCPS._validate_housing_assistance_microsimulation(
                 data,