Skip to content

Commit f5fd828

Browse files
committed
Temporarily disable grouped target loss
1 parent 710ba7a commit f5fd828

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

changelog.d/1030.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Temporarily disable grouped target loss during unified L0 calibration.

policyengine_us_data/calibration/unified_calibration.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
build_checkpoint_signature,
4242
checkpoint_signature_mismatches,
4343
)
44-
from policyengine_us_data.calibration.calibration_utils import (
45-
create_target_groups,
46-
)
4744
from policyengine_us_data.pipeline_metadata import pipeline_node
4845
from policyengine_us_data.stage_contracts.calibration_package import (
4946
CalibrationPackageParameters,
@@ -1363,7 +1360,9 @@ def run_calibration(
13631360

13641361
initial_weights = package.get("initial_weights")
13651362
targets = targets_df["value"].values
1366-
target_groups, _ = create_target_groups(targets_df)
1363+
# Temporarily disable grouped target loss until target precedence
1364+
# and tolerance handling can make grouped fitting safe.
1365+
target_groups = None
13671366
row_sums = np.array(X_sparse.sum(axis=1)).flatten()
13681367
pkg_achievable = row_sums > 0
13691368
weights = fit_l0_weights(
@@ -1704,7 +1703,9 @@ def run_calibration(
17041703

17051704
# Step 7: L0 calibration
17061705
targets = targets_df["value"].values
1707-
target_groups, _ = create_target_groups(targets_df)
1706+
# Temporarily disable grouped target loss until target precedence
1707+
# and tolerance handling can make grouped fitting safe.
1708+
target_groups = None
17081709

17091710
row_sums = np.array(X_sparse.sum(axis=1)).flatten()
17101711
achievable = row_sums > 0

0 commit comments

Comments
 (0)