Skip to content

Add Stage 1 command status boundary#1070

Merged
anth-volk merged 4 commits into
mainfrom
agent/stage-1/pr-3-command-substep-status
May 21, 2026
Merged

Add Stage 1 command status boundary#1070
anth-volk merged 4 commits into
mainfrom
agent/stage-1/pr-3-command-substep-status

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

Fixes #1069

Summary

  • Add Stage 1 command, result, status, and coordinator helpers for structured execution records.
  • Route run_script and run_script_logged through CommandRunner while preserving streamed logs, command order, and checkpoint behavior.
  • Wrap Modal dataset-build script execution in explicit substep recording, including completed, failed, and skipped substep states.

Validation

  • ruff check modal_app/data_build.py policyengine_us_data/build_datasets/__init__.py policyengine_us_data/build_datasets/commands.py policyengine_us_data/build_datasets/coordinator.py policyengine_us_data/build_datasets/results.py policyengine_us_data/build_datasets/status.py tests/unit/test_build_dataset_commands.py tests/unit/test_build_dataset_coordinator.py
  • ruff format --check modal_app/data_build.py policyengine_us_data/build_datasets/__init__.py policyengine_us_data/build_datasets/commands.py policyengine_us_data/build_datasets/coordinator.py policyengine_us_data/build_datasets/results.py policyengine_us_data/build_datasets/status.py tests/unit/test_build_dataset_commands.py tests/unit/test_build_dataset_coordinator.py
  • uv run --no-sync pytest tests/unit/test_build_dataset_commands.py tests/unit/test_build_dataset_coordinator.py tests/unit/test_modal_data_build.py
  • uv run --no-sync pytest tests/unit/test_build_dataset_commands.py tests/unit/test_build_dataset_coordinator.py tests/unit/test_modal_data_build.py tests/unit/test_pipeline_doc_guards.py tests/unit/test_pipeline_docs_extractor.py
  • uv run --no-sync --with pyyaml python scripts/run_quality_guards.py
  • uv run --no-sync --with pyyaml python scripts/extract_pipeline_docs.py --json /private/tmp/stage1-pr3-docs/pipeline_map.json --api-json /private/tmp/stage1-pr3-docs/pipeline_api.json --markdown /private/tmp/stage1-pr3-docs/pipeline-map.md
  • make lint

@anth-volk anth-volk force-pushed the agent/stage-1/pr-2-build-context-artifact-staging branch 4 times, most recently from 1c95362 to 9877333 Compare May 21, 2026 17:11
@anth-volk anth-volk changed the base branch from agent/stage-1/pr-2-build-context-artifact-staging to main May 21, 2026 17:50
@anth-volk anth-volk force-pushed the agent/stage-1/pr-3-command-substep-status branch 4 times, most recently from c2e3805 to 454cf30 Compare May 21, 2026 19:26
@anth-volk anth-volk force-pushed the agent/stage-1/pr-3-command-substep-status branch from 454cf30 to 056c46f Compare May 21, 2026 19:33
@anth-volk anth-volk marked this pull request as ready for review May 21, 2026 21:23
@anth-volk anth-volk merged commit 5a87bc4 into main May 21, 2026
13 checks passed
@anth-volk anth-volk deleted the agent/stage-1/pr-3-command-substep-status branch May 21, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stage 1 command runner and substep status boundary

1 participant