Review-fix round 6: clear final should-address items

- Spell out "Employment-Sponsored Subsidy" instead of "ESS" acronym in
  3 parameter descriptions (ess_window_months, activity_hours_ess_year_1,
  activity_hours_ess_year_2).
- Simplify hhs_smi access in is_ar_sra_income_eligible and ar_sra_income_tier:
  drop the explicit period.this_year + /MONTHS_IN_YEAR pattern in favor of
  reading the YEAR-defined hhs_smi at MONTH period (core auto-converts the
  USD flow variable annual->monthly).

146 AR SRA tests pass; all critical and should-address findings from
multi-round /review-program now cleared.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hua7450

policyengine_us/parameters/gov/states/ar/ade/oec/sra/eligibility/activity_hours_ess_year_1.yaml

@@ -1,4 +1,4 @@
-description: Arkansas sets this minimum weekly activity hours threshold for at least one adult in an ESS Year 1 household under the School Readiness Assistance program.
+description: Arkansas sets this minimum weekly activity hours threshold for at least one adult in an Employment-Sponsored Subsidy Year 1 household under the School Readiness Assistance program.
 values:
   2025-10-01: 20
 

policyengine_us/parameters/gov/states/ar/ade/oec/sra/eligibility/activity_hours_ess_year_2.yaml

@@ -1,4 +1,4 @@
-description: Arkansas sets this minimum weekly activity hours threshold for at least one adult in an ESS Year 2 household under the School Readiness Assistance program.
+description: Arkansas sets this minimum weekly activity hours threshold for at least one adult in an Employment-Sponsored Subsidy Year 2 household under the School Readiness Assistance program.
 values:
   2025-10-01: 25
 

policyengine_us/parameters/gov/states/ar/ade/oec/sra/eligibility/ess_window_months.yaml

@@ -1,4 +1,4 @@
-description: Arkansas limits the ESS post-Transitional Employment Assistance window to this many months under the School Readiness Assistance program.
+description: Arkansas limits the Employment-Sponsored Subsidy post-Transitional Employment Assistance window to this many months under the School Readiness Assistance program.
 values:
   2025-10-01: 24
 

policyengine_us/variables/gov/states/ar/ade/oec/sra/ar_sra_income_tier.py

@@ -20,7 +20,7 @@ class ar_sra_income_tier(Variable):
     def formula(spm_unit, period, parameters):
         p = parameters(period).gov.states.ar.ade.oec.sra
         monthly_income = spm_unit("ar_sra_countable_income", period)
-        monthly_smi = spm_unit("hhs_smi", period.this_year) / MONTHS_IN_YEAR
+        monthly_smi = spm_unit("hhs_smi", period)
         ratio = where(monthly_smi > 0, monthly_income / monthly_smi, np.inf)
         return select(
             [

policyengine_us/variables/gov/states/ar/ade/oec/sra/eligibility/is_ar_sra_income_eligible.py

@@ -12,7 +12,5 @@ class is_ar_sra_income_eligible(Variable):
     def formula(spm_unit, period, parameters):
         p = parameters(period).gov.states.ar.ade.oec.sra.eligibility
         monthly_income = spm_unit("ar_sra_countable_income", period)
-        monthly_smi_limit = (
-            spm_unit("hhs_smi", period.this_year) * p.income_smi_rate / MONTHS_IN_YEAR
-        )
+        monthly_smi_limit = spm_unit("hhs_smi", period) * p.income_smi_rate
         return monthly_income <= monthly_smi_limit