Skip to content

Replace memory allocation type to pointer based to avoid deep-call copying#2

Open
fxllenfx wants to merge 2 commits into
PolskaKrowa:mainfrom
fxllenfx:main
Open

Replace memory allocation type to pointer based to avoid deep-call copying#2
fxllenfx wants to merge 2 commits into
PolskaKrowa:mainfrom
fxllenfx:main

Conversation

@fxllenfx
Copy link
Copy Markdown

yes

@PolskaKrowa PolskaKrowa changed the title fixed a huge memory leak Replace memory allocation type to pointer based to avoid deep-call copying May 18, 2026
@PolskaKrowa
Copy link
Copy Markdown
Owner

Try looking at the contributing.md file before making a pull request.

Also, the pointer association that you used does not actually fix a "huge memory leak" but only reduces memory requirements by a few kilobytes.
Actually fixing a memory leak would require meticulous temporary object freeing and thorough testing with valgrind. Were those conditions met?

I'll also like to ask about your BWR interface files. The whole premise of this project is to allow people to make nuclear physics simulations, not just BWR simulations. Making a C interface would probably include modifying the existing interface to implement all of the provided functions from the internal library into C callable functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants