Skip to content

Commit f4086e3

Browse files
committed
tools/cmake: carry preset.cmake DESCRIPTION quoting fix
Same one-char fix as pytorch#19117 (and our PR #2): the DESCRIPTION argument to `set(...CACHE TYPE DOCSTRING)` was expanded unquoted, so multi-word descriptions on STRING options passed via `-D` spilled their trailing words into subsequent set() args. This was latent until PR #3 introduced EXECUTORCH_VULKAN_FP16_PRECISION with a multi-word help string — builds that set it (e.g. via scripts/build_android_library.sh forwarding the env var) then fail. Carried here so this branch remains self-contained and buildable independent of the merge order of PR #2. Drops cleanly after PR #2 lands; git will treat the duplicate line as a no-op.
1 parent 9ad1610 commit f4086e3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/cmake/common/preset.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,12 @@ macro(define_overridable_option NAME DESCRIPTION VALUE_TYPE DEFAULT_VALUE)
8282
if(DEFINED ${NAME} AND NOT DEFINED CACHE{${NAME}})
8383
set(${NAME}
8484
${${NAME}}
85-
CACHE ${VALUE_TYPE} ${DESCRIPTION} FORCE
85+
CACHE ${VALUE_TYPE} "${DESCRIPTION}" FORCE
8686
)
8787
else()
8888
set(${NAME}
8989
${DEFAULT_VALUE}
90-
CACHE ${VALUE_TYPE} ${DESCRIPTION}
90+
CACHE ${VALUE_TYPE} "${DESCRIPTION}"
9191
)
9292
endif()
9393

0 commit comments

Comments
 (0)