Add scrolling sheet music view#385
Open
mavdey wants to merge 2 commits into
Open
Conversation
Render MIDI notes on synchronized treble and bass staves above the waterfall, keeping the playback cursor fixed at the center while notation and bar lines scroll horizontally. Support note heads, stems, accidentals, ledger lines, duration variants, track colors, direct drag resizing, and persistent visibility and height settings.
Replace fallback Unicode clefs and procedural note shapes with a transparent notation atlas and an instanced GPU sprite pipeline. Add recognizable treble and bass clefs, quarter, half and whole notes, and sharp accidentals while preserving per-track tint colors and the centered scrolling behavior.
Owner
|
Tried to play with it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a centered scrolling sheet music panel above the keyboard.
This change renders sheet music using notation sprites and keeps the current playback position centered while the song is playing. The goal is to make note reading easier by showing traditional sheet notation alongside the existing falling-note view.
Changes included:
This is an initial implementation and may need further UI/UX adjustments based on feedback.