fix random ass crash

Author: Wyvest

src/main/java/org/polyfrost/polyplus/mixin/client/cosmetics/AbstractClientPlayerMixin.java

@@ -16,24 +16,34 @@
 @Mixin(AbstractClientPlayer.class)
 public abstract class AbstractClientPlayerMixin implements PlayerEmotesAccess, PlayerCosmeticsAccess {
     @Unique
-    private final EmoteController polyplus$emoteController = new EmoteController();
+    private EmoteController polyplus$emoteController;
 
     @Unique
-    private final CosmeticEquipment polyplus$cosmeticEquipment = new CosmeticEquipment();
+    private CosmeticEquipment polyplus$cosmeticEquipment;
 
     @Override
     public EmoteController polyplus$emoteController() {
-        return polyplus$emoteController;
+        EmoteController controller = polyplus$emoteController;
+        if (controller == null) {
+            controller = new EmoteController();
+            polyplus$emoteController = controller;
+        }
+        return controller;
     }
 
     @Override
     public CosmeticEquipment polyplus$cosmeticEquipment() {
-        return polyplus$cosmeticEquipment;
+        CosmeticEquipment equipment = polyplus$cosmeticEquipment;
+        if (equipment == null) {
+            equipment = new CosmeticEquipment();
+            polyplus$cosmeticEquipment = equipment;
+        }
+        return equipment;
     }
 
     @Inject(method = "tick", at = @At("RETURN"))
     private void polyplus$tickEmote(CallbackInfo ci) {
-        polyplus$emoteController.tick((AbstractClientPlayer) (Object) this);
+        polyplus$emoteController().tick((AbstractClientPlayer) (Object) this);
     }
 }
 //?}

src/main/java/org/polyfrost/polyplus/mixin/client/cosmetics/AvatarRenderStateMixin.java

@@ -23,14 +23,19 @@
 *///?}
 public class AvatarRenderStateMixin implements AvatarEmoteRenderAccess {
     @Unique
-    private EmoteController polyplus$boundEmoteController = new EmoteController();
+    private EmoteController polyplus$boundEmoteController;
 
     @Unique
-    private Map<String, BoneTransform> polyplus$lastEmoteSample = Collections.emptyMap();
+    private Map<String, BoneTransform> polyplus$lastEmoteSample;
 
     @Override
     public EmoteController polyplus$boundEmoteController() {
-        return polyplus$boundEmoteController;
+        EmoteController controller = polyplus$boundEmoteController;
+        if (controller == null) {
+            controller = new EmoteController();
+            polyplus$boundEmoteController = controller;
+        }
+        return controller;
     }
 
     @Override
@@ -40,12 +45,13 @@ public class AvatarRenderStateMixin implements AvatarEmoteRenderAccess {
 
     @Override
     public Map<String, BoneTransform> polyplus$lastEmoteSample() {
-        return polyplus$lastEmoteSample;
+        Map<String, BoneTransform> sample = polyplus$lastEmoteSample;
+        return sample == null ? Collections.emptyMap() : sample;
     }
 
     @Override
     public void polyplus$setLastEmoteSample(Map<String, BoneTransform> sample) {
-        polyplus$lastEmoteSample = sample;
+        polyplus$lastEmoteSample = sample == null ? Collections.emptyMap() : sample;
     }
 }
 //?}

src/main/java/org/polyfrost/polyplus/mixin/client/cosmetics/AvatarRendererMixin.java

@@ -44,9 +44,11 @@ public class AvatarRendererMixin {
 
         EmoteController controller = entity instanceof PlayerEmotesAccess playerAccess
             ? playerAccess.polyplus$emoteController()
-            : new EmoteController();
+            : null;
 
-        renderAccess.polyplus$bindEmoteController(controller);
+        if (controller != null) {
+            renderAccess.polyplus$bindEmoteController(controller);
+        }
     }
 }
 //?}