use a more standard way of creating new warns

Author: GreemDev

src/Bot/Systems/Commands/Interaction/Attributes/RequireGuildAdminPreconditionAttribute.cs

@@ -15,7 +15,7 @@ IServiceProvider services
             return PreconditionResult.FromError("This command can only be executed in a guild.");
 
         var db = services.Get<DatabaseService>();
-        var data = await db.GetDataAsync(context.Guild.Id);
+        var data = db.GetData(context.Guild.Id);
 
         var u = await context.Guild.GetUserAsync(context.User.Id);
 

src/Bot/Systems/Commands/Interaction/Attributes/RequireGuildModeratorPreconditionAttribute.cs

@@ -15,7 +15,7 @@ IServiceProvider services
             return PreconditionResult.FromError("This command can only be executed in a guild.");
 
         var db = services.Get<DatabaseService>();
-        var data = await db.GetDataAsync(context.Guild.Id);
+        var data = db.GetData(context.Guild.Id);
 
         var u = 
             context.Guild.Cast<SocketGuild>()?.GetUser(context.User.Id) 

src/Bot/Systems/Database/DatabaseService.cs

@@ -88,8 +88,6 @@ public GuildDataV2 GetData(ulong id)
 
     public GuildDataV2 GetData(IGuild guild) => GetData(guild.Id);
     public HashSet<GuildDataV2> GetAllData() => _guildDataV2.ValueLock(() => _guildDataV2.FindAll().ToHashSet());
-
-    public ValueTask<GuildDataV2> GetDataAsync(ulong id) => new(GetData(id));
 
     public void CreateGuildDataIfNotExists(IGuild guild) =>
         _guildDataV2.LockedRef(coll =>
@@ -139,16 +137,16 @@ public bool TryDeleteReminder(Reminder.Reminder reminder) =>
 
     public async Task WarnAsync(IUser issuer, IGuildUser member, string reason)
     {
-        var data = await GetDataAsync(member.GuildId);
-        
-        data.Moderation.AddWarn(warn =>
+        var data = GetData(member.GuildId);
+
+        data.Moderation.Warns.Add(new WarnV2
         {
-            warn.Issuer = issuer.Id;
-            warn.Target = member.Id;
-            warn.Reason = reason;
-            warn.Date = DateTimeOffset.Now;
+            Issuer = issuer.Id,
+            Target = member.Id,
+            Reason = reason,
+            Date = DateTimeOffset.Now
         });
-        
+
         Save(data);
 
         var e = new EmbedBuilder().WithSuccessColor().WithAuthor(issuer)

src/Bot/Systems/Starboard/StarboardService.cs

@@ -174,7 +174,7 @@ public async Task HandleReactionsClearAsync(Cacheable<IUserMessage, ulong> cache
         var guildId = channel.Guild.Id;
         var messageId = cachedMessage.Id;
 
-        var starboard = (await _db.GetDataAsync(guildId)).Settings.Starboard;
+        var starboard = _db.GetData(guildId).Settings.Starboard;
 
         if (!starboard.Enabled) return;
 
@@ -292,7 +292,7 @@ public EmbedBuilder GetStarboardEmbed(IMessage message)
 
     private async Task<IMessage> PostToStarboardAsync(IMessage message, int starCount)
     {
-        var data = await _db.GetDataAsync(message.Channel.Cast<IGuildChannel>().GuildId);
+        var data = _db.GetData(message.Channel.Cast<IGuildChannel>().GuildId);
 
         var starboardChannel = _client.GetChannel(data.Settings.Starboard.Channel);
         if (starboardChannel is not ITextChannel starboardTextChannel)

src/Bot/Systems/UserFilter/UserFilterService.cs

@@ -15,7 +15,7 @@ public Task OnUserJoined(UserJoinedEventArgs args)
     {
         ExecuteBackgroundAsync(async () =>
         {
-            var data = await _db.GetDataAsync(args.Guild.Id);
+            var data = _db.GetData(args.Guild.Id);
             var idsToClear = await data.StarscriptTables.UserFilter
                 .HandleAsync(args.Guild, args.User)
                 .ToArrayAsync();