Skip to content
This repository was archived by the owner on May 25, 2026. It is now read-only.
This repository was archived by the owner on May 25, 2026. It is now read-only.

get_balance_allowance and update_balance_allowance crash with AttributeError when params not passed #306

@Sush78

Description

@Sush78

Both get_balance_allowance and update_balance_allowance in client.py declare
params: BalanceAllowanceParams = None but immediately access params.signature_type
without a None check.

Calling either method without params raises an opaque error:

AttributeError: 'NoneType' object has no attribute 'signature_type'

This was also flagged during code review on #224 (async client PR) where the reviewer
noted the same bug exists in the sync client.

Suggested fix: add a guard that raises a clear ValueError before accessing params attributes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions