Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

route-changed fired twice with bad state #245

@tjb1982

Description

@tjb1982

I'm experiencing a problem where when there were queryParams before navigating to a new URL without query params, route-changed is dispatched twice, the first time around with bad state (i.e., contains the old queryParams).

E.g., start with URL:

/context/?param=foo

route-changed is dispatched:

appRout.queryParams === {param: "foo"}

user clicks on <a href="/context">...</a>, and route-changed is dispatched:

appRoute.queryParams === {param: "foo"}

but then route-changed is immediately dispatched a second time:

appRoute.queryParams === {}

The work-around I'm using is wrapping my route-changed event handler in a 0ms-debounce, which allows the event loop to recycle and finish the required mutations to the state of the queryParams. However, route-changed is still dispatched twice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions