Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

disableDrag property not used #232

@jarrodek

Description

@jarrodek

Description

The disableDrag property is not used anywhere in the code and therefore it is not working as intended.
I believe that _scroll() function supposed to have the following condition but it is missing.

_scroll: function(e, detail) {
  if (!this.scrollable || this.disableDrag) {
    return;
  }
  ...
},

Expected outcome

Tabs are not scrolling when used in the following way:

<paper-tabs scrollable disable-drag>
   ...
</paper-tabs>

Actual outcome

You can still drag the tabs. It is a problem when you implement your own draggable tabs so you can rearrange pages.

Steps to reproduce

  1. Create enough tabs so they won't fit into the available area.
  2. Set both scrollable and disable-drag attributes or corresponding properties.
  3. Drag the list of tabs

Browsers Affected

It's not dependent on browser.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions