minor version bump because of non trivial functionality change

refactorings

Author: ChaosEngine

src/Pomelo.Extensions.Caching.MySql/MySqlCacheOptions.cs

@@ -72,7 +72,7 @@ MySqlCacheOptions IOptions<MySqlCacheOptions>.Value
 		{
 			get
 			{
-				//correct empty conn strings if possible more inteligently
+				//correct empty conn strings if possible more intelligently
 				WriteConnectionString = WriteConnectionString ?? ConnectionString;
 				ReadConnectionString = (ReadConnectionString ?? ConnectionString) ?? WriteConnectionString;
 

src/Pomelo.Extensions.Caching.MySql/MySqlCacheServiceCollectionExtensions.cs

@@ -39,7 +39,6 @@ public static IServiceCollection AddDistributedMySqlCache(this IServiceCollectio
         }
 
 		// to enable unit testing
-		/// TODO: make this internal again
 		internal static void AddMySqlCacheServices(IServiceCollection services)
         {
             services.Add(ServiceDescriptor.Singleton<IDistributedCache, MySqlCache>());

src/Pomelo.Extensions.Caching.MySql/MySqlParameterCollectionExtensions.cs

@@ -6,9 +6,6 @@
 
 namespace Pomelo.Extensions.Caching.MySql
 {
-	/// <summary>
-	/// TODO: make this class internal again
-	/// </summary>
 	internal static class MySqlParameterCollectionExtensions
     {
         // For all values where the length is less than the below value, try setting the size of the

src/Pomelo.Extensions.Caching.MySql/Pomelo.Extensions.Caching.MySql.csproj

@@ -11,7 +11,7 @@
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <Version>2.1.6</Version>
+    <Version>2.2.0</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>Pomelo.snk</AssemblyOriginatorKeyFile>

src/Pomelo.Extensions.Caching.MySqlConfig.Tools/Pomelo.Extensions.Caching.MySqlConfig.Tools.csproj

@@ -18,10 +18,10 @@
     <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <RootNamespace>Pomelo.Extensions.Caching.MySqlConfig.Tools</RootNamespace>
-    <Version>2.1.6</Version>
+    <Version>2.2.0</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
-    <AssemblyVersion>2.1.6.0</AssemblyVersion>
+    <AssemblyVersion>2.2.0.0</AssemblyVersion>
     <IsPackable>true</IsPackable>
     <ToolCommandName>dotnet-mysql-cache</ToolCommandName>
     <PackAsTool>true</PackAsTool>

src/Pomelo.Extensions.Caching.MySqlConfig.Tools/Program.cs

@@ -169,12 +169,6 @@ public int Run(string[] args)
 							await command.ExecuteNonQueryAsync(token);
 						}
 
-						//using (var command = new MySqlCommand(sqlQueries.CreateNonClusteredIndexOnExpirationTime,
-						//	connection, transaction))
-						//{
-						//	await command.ExecuteNonQueryAsync(token);
-						//}
-
 						transaction.Commit();
 
 						await Out.WriteLineAsync("Table and index were created successfully.");

src/Pomelo.Extensions.Caching.MySqlConfig.Tools/SqlQueries.cs

@@ -22,9 +22,6 @@ internal class MySqlQueries
 				"KEY `Index_ExpiresAtTime` (`ExpiresAtTime`)" +
 			")";
 
-		//private const string CreateNonClusteredIndexOnExpirationTimeFormat
-		//	= "CREATE NONCLUSTERED INDEX Index_ExpiresAtTime ON {0}(ExpiresAtTime)";
-
 		private const string TableInfoFormat =
 			 "SELECT TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE " +
 			 "FROM INFORMATION_SCHEMA.TABLES " +
@@ -43,18 +40,14 @@ public MySqlQueries(string databaseName, string tableName)
 				(string.IsNullOrEmpty(databaseName) ? "" : DelimitIdentifier(databaseName) + '.'),
 				DelimitIdentifier(tableName)
 				);
+
 			CreateTable = string.Format(CreateTableFormat, tableNameWithDatabase);
-			//CreateNonClusteredIndexOnExpirationTime = string.Format(
-			//	CreateNonClusteredIndexOnExpirationTimeFormat,
-			//	tableNameWithDatabase);
 			TableInfo = string.Format(TableInfoFormat, EscapeLiteral(tableName)) + 
 				(string.IsNullOrEmpty(databaseName) ? "" : $"AND TABLE_SCHEMA = '{EscapeLiteral(databaseName)}'");
 		}
 
 		public string CreateTable { get; }
 
-		//public string CreateNonClusteredIndexOnExpirationTime { get; }
-
 		public string TableInfo { get; }
 
 		// From EF's SqlServerQuerySqlGenerator

test/Pomelo.Extensions.Caching.MySql.Tests/Pomelo.Extensions.Caching.MySql.Tests.csproj

@@ -9,7 +9,7 @@
 	  <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
-    <Version>2.1.6</Version>
+    <Version>2.2.0</Version>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>Pomelo.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>