fix: EyeAngles can now be properly acquired. Vectors use special created copy allocation function

Co-Authored-By: NULLderef <45497774+0xNULLderef@users.noreply.github.com>

Author: OrsellGit

README.md

@@ -15,35 +15,35 @@ The purpose of this plugin is to patch Portal 2 to make the mod work as well as
 Note: While represented in C++, below functions are for Squirrel. `const char*` type is translated to `string` type. `byte`, `short`, and `long` types are translated to `integer` type. `void` types are simply the `function` type in Squirrel. `HSCRIPT` is a VScript script handle which is an entity instance.
 
 ```c++
-void          printlP2MM(int level, bool dev, const char* pMsgFormat);   | "Logging for the P2MM VScript. The log message must be passed as a string or it will error."
-const char*   GetPlayerName(int playerIndex);                            | "Gets player username by their entity index."
-int           GetSteamID(int playerIndex);                               | "Gets the account ID component of player SteamID by the player's entity index."
-int           UserIDToPlayerIndex(int userid);                           | "Get the player's entity index by their userid."
-bool          IsMapValid(const char* map);                               | "Returns true is the supplied string is a available map to load and run."
-int           GetDeveloperLevelP2MM();                                   | "Returns the value of ConVar p2mm_developer."
-bool          IsDedicatedServer();                                       | "Returns true if this is a dedicated server."
-void          InitializeEntity(HSCRIPT ent);                             | "Initializes, spawns, then activates an entity in the map. Create a entity using CreateByClassname, then use this function on its handle. Note: Not all entities will work even after being initialized with this function."
-void          SendToChat(const char* msg, int playerIndex);              | "Sends a raw message to the chat HUD. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
-const char*   GetGameMainDir();                                          | "Returns the current game directory. Ex. portal2"
-const char*   GetGameRootDir();                                          | "Returns the current root game directory. Ex. Portal 2"
-void          CallFirstRunPrompt();                                      | "Shows the first run prompt if enabled in config.nut."
-int           GetConVarInt(const char* cvName);                          | "Get the integer value of a ConVar."
-const char*   GetConVarString(const char* cvName);                       | "Get the string value of a ConVar."
-void          SetConVarInt(const char* cvName, int newValue);            | "Set the integer value of a ConVar."
-void          SetConVarString(const char* cvName, const char* newValue); | "Set the string value of a ConVar."
-HSCRIPT       PlayerByIndex(int playerIndex);                            | "Takes the player's entity index and returns the player's script handle."
-void          RespawnPlayer(int playerIndex);                            | "Respawn the a player by their entity index."
-void          SetFlashlightState(int playerIndex, bool enable);          | "Set the flashlight for a player on or off."
-void          ConsolePrint(int playerIndex, const char* msg);            | "Print a message to a player's console, unlike printl() which is just the host. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
-void          ClientPrint(int playerIndex, const char* msg);             | "Print a message to the top center position of a player's screen. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
-void          HudPrint(int playerIndex, const char* msg, Vector(float x, float y, int channel), int effect, float fxTime, Vector RGB1, float alpha1, Vector RGB2, float alpha2, Vector(float fadeinTime, float fadeoutTime, float holdTime));
-                                                                         | "Print a message to the screen based on what the game_text entity does, with many values to set. See Valve Developer Commentary for the game_text entity to see what each field does. Vectors are in place for sets of RGB values. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
-int           GetMaxPlayers();                                           | "Return max amount of players that can be in the server."
-void          ShowScoreboard(int playerIndex, bool bEnable);             | "Enable or disable displaying the score board a player."
-void          RemovePlayerUI(const int playerIndex, const bool bBanning) | "Display UI for either banning or kicking so host can ban or kick a player. WIP, need to manually open pause menu to see VGUI"
-float         TraceLineEx(const Vector& vecAbsStart, const Vector& vecAbsEnd, const int mask, const HSCRIPT ignore, const int collisionGroup)
-                                                                         | "Improved version of TraceLine that allows for checking with bit masks and collision groups. Returns a fraction of line where a collision occured, or if in a solid, the amount spent outside the solid."
-const Vector& Script_EyeAngles(const int playerIndex)                    | "Get the eye angles of a player. WIP seems to crash."
+void        printlP2MM(int level, bool dev, const char* pMsgFormat);   | "Logging for the P2MM VScript. The log message must be passed as a string or it will error."
+const char* GetPlayerName(int playerIndex);                            | "Gets player username by their entity index."
+int         GetSteamID(int playerIndex);                               | "Gets the account ID component of player SteamID by the player's entity index."
+int         UserIDToPlayerIndex(int userid);                           | "Get the player's entity index by their userid."
+bool        IsMapValid(const char* map);                               | "Returns true is the supplied string is a available map to load and run."
+int         GetDeveloperLevelP2MM();                                   | "Returns the value of ConVar p2mm_developer."
+bool        IsDedicatedServer();                                       | "Returns true if this is a dedicated server."
+void        InitializeEntity(HSCRIPT ent);                             | "Initializes, spawns, then activates an entity in the map. Create a entity using CreateByClassname, then use this function on its handle. Note: Not all entities will work even after being initialized with this function."
+void        SendToChat(const char* msg, int playerIndex);              | "Sends a raw message to the chat HUD. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
+const char* GetGameMainDir();                                          | "Returns the current game directory. Ex. portal2"
+const char* GetGameRootDir();                                          | "Returns the current root game directory. Ex. Portal 2"
+void        CallFirstRunPrompt();                                      | "Shows the first run prompt if enabled in config.nut."
+int         GetConVarInt(const char* cvName);                          | "Get the integer value of a ConVar."
+const char* GetConVarString(const char* cvName);                       | "Get the string value of a ConVar."
+void        SetConVarInt(const char* cvName, int newValue);            | "Set the integer value of a ConVar."
+void        SetConVarString(const char* cvName, const char* newValue); | "Set the string value of a ConVar."
+HSCRIPT     PlayerByIndex(int playerIndex);                            | "Takes the player's entity index and returns the player's script handle."
+void        RespawnPlayer(int playerIndex);                            | "Respawn the a player by their entity index."
+void        SetFlashlightState(int playerIndex, bool enable);          | "Set the flashlight for a player on or off."
+void        ConsolePrint(int playerIndex, const char* msg);            | "Print a message to a player's console, unlike printl() which is just the host. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
+void        ClientPrint(int playerIndex, const char* msg);             | "Print a message to the top center position of a player's screen. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
+void        HudPrint(int playerIndex, const char* msg, Vector(float x, float y, int channel), int effect, float fxTime, Vector RGB1, float alpha1, Vector RGB2, float alpha2, Vector(float fadeinTime, float fadeoutTime, float holdTime));
+                                                                       | "Print a message to the screen based on what the game_text entity does, with many values to set. See Valve Developer Commentary for the game_text entity to see what each field does. Vectors are in place for sets of RGB values. Specifying no playerIndex or 0 sends to all players. Supports printing localization strings but those that require formatting can't be formatted."
+int         GetMaxPlayers();                                           | "Return max amount of players that can be in the server."
+void        ShowScoreboard(int playerIndex, bool bEnable);             | "Enable or disable displaying the score board a player."
+void        RemovePlayerUI(const int playerIndex, const bool bBanning) | "Display UI for either banning or kicking so host can ban or kick a player. WIP, need to manually open pause menu to see VGUI"
+float       TraceLineEx(const Vector& vecAbsStart, const Vector& vecAbsEnd, const int mask, const HSCRIPT ignore, const int collisionGroup)
+                                                                       | "Improved version of TraceLine that allows for checking with bit masks and collision groups. Returns a fraction of line where a collision occured, or if in a solid, the amount spent outside the solid."
+Vector      Script_EyeAngles(const int playerIndex)                    | "Get the eye angles of a player. WIP seems to crash."
 
 ```
 

public/mathlib/vector.h

@@ -206,6 +206,14 @@ class Vector
 	operator VectorByValue &()				{ return *((VectorByValue *)(this)); }
 	operator const VectorByValue &() const	{ return *((const VectorByValue *)(this)); }
 
+	// allocate a vector using tier0's memalloc and copy to it from a source vector
+	static inline Vector* Tier0CopyAlloc(const Vector &vOther)
+	{
+		Vector* v = (Vector*)MemAlloc_Alloc(sizeof(Vector));
+		v->x = vOther.x; v->y = vOther.y; v->z = vOther.z;
+		return v;
+	}
+
 #ifndef VECTOR_NO_SLOW_OPERATIONS
 	// copy constructors
 //	Vector(const Vector &vOther);

public/vscript/vscript_templates.h

@@ -320,7 +320,8 @@ inline FUNCPTR_TYPE ScriptConvertFuncPtrFromVoid( void *p )
 			} \
 			*pReturn = ((FUNC_TYPE)pFunction)( SCRIPT_BINDING_ARGS_##N ); \
 			if ( pReturn->m_type == FIELD_VECTOR ) \
-				pReturn->m_pVector = new Vector(*pReturn->m_pVector); \
+				/* new Vector uses the std allocator, this needs tier0 memalloc */ \
+				pReturn->m_pVector = Vector::Tier0CopyAlloc(*pReturn->m_pVector); \
  			return true; \
  		} \
 	}; \
@@ -360,7 +361,8 @@ inline FUNCPTR_TYPE ScriptConvertFuncPtrFromVoid( void *p )
 			} \
 			*pReturn = (((OBJECT_TYPE_PTR)(pContext))->*ScriptConvertFuncPtrFromVoid<FUNC_TYPE>(pFunction))( SCRIPT_BINDING_ARGS_##N ); \
 			if ( pReturn->m_type == FIELD_VECTOR ) \
-				pReturn->m_pVector = new Vector(*pReturn->m_pVector); \
+				/* new Vector uses the std allocator, this needs tier0 memalloc */ \
+				pReturn->m_pVector = Vector::Tier0CopyAlloc(*pReturn->m_pVector); \
  			return true; \
  		} \
 	}; \

vscript.cpp

@@ -321,7 +321,7 @@ static float Script_UTIL_TraceLine(const Vector& vecAbsStart, const Vector& vecA
  * @param playerIndex Player index to get angles of.
  * @return Vector of player eye angles.
  */
-static const Vector& Script_EyeAngles(const int playerIndex)
+static Vector Script_EyeAngles(const int playerIndex)
 {
 	const QAngle eyeAngles = CBasePlayer__EyeAngles(playerIndex);
 	return Vector(eyeAngles.x, eyeAngles.y, eyeAngles.z);