feat: passthrough oai embed response without opening body#1053
Merged
Conversation
narengogi
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author Description
(optional)
Description
🔄 What Changed
This PR implements a performance optimization for OpenAI embedding responses by avoiding unnecessary JSON parsing when no synchronous hooks are present. The code now checks for the presence of sync hooks and only parses the response body when needed, otherwise passing through the response directly.
🔍 Impact of the Change
This change improves performance for embedding API calls by reducing unnecessary JSON parsing operations, particularly beneficial for high-volume embedding requests.
📁 Total Files Changed
5 files modified with 42 additions and 13 deletions.
🧪 Test Added
N/A - No explicit tests were added in this PR.
🔒 Security Vulnerabilities
No security vulnerabilities were introduced.
Motivation
To improve performance by avoiding unnecessary JSON parsing operations for OpenAI embedding responses when no synchronous hooks are active.
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
N/A
Checklist
Related Issues
N/A
Quality Recommendations
Add unit tests to verify the new passthrough behavior works correctly
Add error handling for the case where JSON parsing fails but is required
Add documentation comments explaining the purpose of the
areSyncHooksAvailableflagConsider adding logging to track when responses are passed through vs parsed