[FIX] remove /v1 from path for azure openai#1056
Merged
VisargD merged 2 commits intoApr 23, 2025
Merged
Conversation
VisargD
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author Description
Description
🔄 What Changed
This PR removes the
/v1prefix from API paths for Azure OpenAI requests. The implementation now uses a direct string replacement approach instead of splitting the URL by/v1. Additionally, multiple duplicate case statements with identical implementations have been consolidated to improve code maintainability.🔍 Impact of the Change
This change ensures proper URL construction when communicating with Azure OpenAI endpoints, fixing potential issues with API requests.
📁 Total Files Changed
1 file modified:
src/providers/azure-openai/api.ts(3 additions, 16 deletions)🧪 Test Added
N/A - No tests were added in this PR.
🔒 Security Vulnerabilities
N/A - No security vulnerabilities were addressed or introduced.
Motivation
Azure OpenAI API endpoints do not require the
/v1prefix in the path, and including it was causing issues with API requests.Type of Change
How Has This Been Tested?
Screenshots (if applicable)
N/A
Checklist
Related Issues
N/A
Quality Recommendations
Add unit tests to verify the URL path handling for Azure OpenAI API requests
Add comments explaining why
/v1needs to be removed from the path for Azure OpenAIConsider adding error handling for URL parsing to handle potential exceptions
Add logging to track URL transformations for debugging purposes