refactored tryPost by roh26it · Pull Request #1121 · Portkey-AI/gateway

roh26it · 2025-06-03T14:27:15Z

Description

Cleaning up handlerUtils in preparation to add more features here.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
[x ] Refactoring (no functional changes)

How Has This Been Tested?

Unit Tests
Integration Tests
[x ] Manual Testing

Checklist

[x ] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

matterai-app

This PR does an excellent job of refactoring the tryPost functionality into a more modular, service-based architecture. The separation of concerns is well-implemented, making the code more maintainable and testable. I've identified a few minor improvements that could enhance the robustness of the implementation.

…re reliable with cloning before saving

narengogi

looks good to me

VisargD · 2025-07-10T15:08:22Z

+    return this;
+  }
+
+  private isComplete(obj: unknown): obj is LogObject {


This feels pretty redundant. We are first doing typeof checks for all the fields and then we are also running zod schema validation. Can we remove this isComplete method?

VisargD · 2025-07-10T15:24:01Z

+import { Context } from 'hono';
+import { RequestContext } from './requestContext';
+
+export class PreRequestValidatorService {


Hey, this also feels redundant. preRequestValidator is something that we accept in the context and it can be set in other middleware.

Creating a class which internally is just making a function call is redundant because I cannot think of any scope of extra functionalities that we will be able to abstract in future with this.

VisargD · 2025-07-10T15:41:23Z

+import { RequestContext } from './requestContext';
+import { AllHookResults } from '../../middlewares/hooks/types';
+
+export class HooksService {


Isn't it better to just add the new methods to the existing class itself? areSyncHooksAvailable, hasResults and hasFailedHooks can be first class citizens instead of this new class taking the decisions.

matterai-app · 2025-07-14T09:21:55Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-16T08:53:26Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-16T10:19:13Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-16T10:24:54Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-16T12:13:00Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-17T10:19:36Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-18T14:41:31Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-18T14:42:39Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-22T09:15:59Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

matterai-app · 2025-07-22T09:30:59Z

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

/matter summary: Generate AI Summary for the PR
/matter review: Generate AI Reviews for the latest commit in the PR
/matter review-full: Generate AI Reviews for the complete PR
/matter release-notes: Generate AI release-notes for the PR
/matter : Chat with your PR with Matter AI Agent
/matter remember : Generate AI memories for the PR
/matter explain: Get an explanation of the PR
/matter help: Show the list of available commands and documentation
Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

refactored tryPost

a7f893b

roh26it requested review from VisargD and Copilot June 3, 2025 14:27

This comment was marked as outdated.

Sign in to view

matterai-app Bot reviewed Jun 3, 2025

View reviewed changes

Comment thread src/handlers/services/responseService.ts

Comment thread src/handlers/handlerUtils.ts

Comment thread src/handlers/services/requestContext.ts

Comment thread src/handlers/services/logsService.ts

roh26it added 16 commits June 4, 2025 23:58

Added tests

68e716b

refactoring for better logging

e5915c7

bug fix: x-portkey-provider was missing in responseHeaders

c1721e2

bug fix: x-portkey-provider was missing in responseHeaders

6347fe3

bug fix: cacheKey was null instead of undefined. Now fixed.

9b7b580

bug fix: cacheStatus wasn't disabled by default. Now fixed.

9b78278

better error handling when logObject is incomplete

1082bd3

bug: responseService.create was returning the wrong data

5aa8b31

adding tests

7bd99d1

bug: set file-purpose header only if it exists

ac58290

bug: bedrock was not receiving the transformedRequestUrl properly

d5dae84

made the log service faster with inline validation without zod and mo…

ad70b4c

…re reliable with cloning before saving

updated tests

716b12a

merge main

e385a58

Allow encoding headers

0dcf529

Better console.errors everywhere

7d75507

This comment was marked as resolved.

Sign in to view

No console.log, all console.errors

39d583e

narengogi reviewed Jun 18, 2025

View reviewed changes

Portkey-AI deleted a comment from matterai-app Bot Jun 18, 2025

Rohit Agarwal and others added 4 commits June 23, 2025 19:06

Remove comments in responseService

d07bce9

moving tests

c2f8119

Added .creds.example.json in tests

88509bc

Removed unused vars

8c1af34

VisargD reviewed Jul 10, 2025

View reviewed changes

Merge branch 'main' into feat/cleanup-handlerutils

69f4da7

Merge branch 'main' into feat/cleanup-handlerutils

245bdf4

VisargD added 2 commits July 16, 2025 14:55

chore: update package lock

6133707

chore: exclude tests dir in rollup config

0728a86

chore: cleanup console logs

a99d4d5

Merge branch 'main' into feat/cleanup-handlerutils

5718005

fix: catch gateway error gracefully

8afa049

merge main into feat/cleanup-handlerutils

f647b02

chore: comment log service is complete call

0cf3d7e

Add cacheKey and cacheStatus again

9b64ce8

Improved executionTime for guardrail retry requests

b6ad9fb

VisargD approved these changes Jul 22, 2025

View reviewed changes

VisargD merged commit 07333a1 into main Jul 22, 2025
1 check passed

This was referenced Jul 22, 2025

fix: stream cache response mapping #1236

Merged

fix: handle provider error logs addition #1241

Merged

fix: set transformed request body in logs service requestParams field #1246

Merged

roh26it deleted the feat/cleanup-handlerutils branch August 13, 2025 10:39

Uh oh!

Conversation

roh26it commented Jun 3, 2025

Description

Type of Change

How Has This Been Tested?

Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

narengogi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VisargD Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

VisargD Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

VisargD Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot commented Jul 14, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 16, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 16, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 16, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 16, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 17, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 18, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 18, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 22, 2025

PR Review Skipped

Command List

Uh oh!

matterai-app Bot commented Jul 22, 2025

PR Review Skipped

Command List

Uh oh!

Uh oh!

Reviewers