fix: Rename Model Whitelist to Allowed Models#1144
Conversation
…st-copy-in-manifest.json Update model whitelist manifest copy
|
Summary By MatterAI
🔄 What ChangedRenamed "Model Whitelist" to "Allowed Models" in the UI display text while maintaining the internal ID as "modelwhitelist". Updated related description texts to reflect the new terminology. 🔍 Impact of the ChangeThis change improves the user interface by using more inclusive language. The functionality remains the same, but the terminology is now more descriptive and avoids potentially problematic language. 📁 Total Files Changed1 file changed with 4 additions and 4 deletions:
🧪 Test AddedN/A - This change only affects UI text and doesn't require functional testing. 🔒Security VulnerabilitiesN/A - No security implications in this change. MotivationTo use more inclusive language by replacing "whitelist" terminology with "allowed models" which is more descriptive and avoids potentially problematic language. Type of Change
How Has This Been Tested?
Screenshots (if applicable)N/A Checklist
Related IssuesAddresses inclusive language concerns by replacing "whitelist" terminology. Tip Quality Recommendations
Sequence DiagramsequenceDiagram
title Rename Model Whitelist to Allowed Models
participant User as User
participant UI as UI Interface
participant Guardrail as Guardrail System
participant ModelFilter as Model Filter
User->>UI: Access model filtering settings
UI->>Guardrail: Load guardrail configuration
Guardrail->>UI: Return configuration with "modelwhitelist" id
Note over UI: UI displays "Allowed Models" instead of "Model Whitelist"
Note over UI: Description updated to "Blocks any request whose model isn't on this list"
Note over UI: Example models shown: "gpt-4o, llama-3-70b, mixtral-8x7b"
Note over UI: Inversion option described as "When on, any model in the list is blocked instead of allowed"
User->>UI: Configure allowed models
UI->>Guardrail: Save configuration with "modelwhitelist" id
Guardrail->>ModelFilter: Apply model filtering based on configuration
ModelFilter->>Guardrail: Filter API requests using beforeRequestHook
|
![matterai-app[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
| "name": "Allowed Models", | ||
| "id": "modelwhitelist", | ||
| "type": "guardrail", |
There was a problem hiding this comment.
🛠️ Code Refactor
Issue: While the display name has been updated to "Allowed Models", the internal ID "modelwhitelist" still uses the old terminology.
Fix: Consider updating the ID to match the new terminology for complete consistency.
Impact: This would make the codebase more consistent and avoid confusion for developers who might see mixed terminology.
| "name": "Allowed Models", | |
| "id": "modelwhitelist", | |
| "type": "guardrail", | |
| \"name\": \"Allowed Models\", | |
| \"id\": \"allowedmodels\", | |
| \"type\": \"guardrail\", |
narengogi
left a comment
narengogi
left a comment
There was a problem hiding this comment.
would recommend making the changes comprehensive by changing the plugin id
|
Note PR Review SkippedPR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file. 📄Files skipped in review
💡Tips to use Matter AICommand List
|
@narengogi - We can change the labels as the first step. Changing ids will break existing implementations. Will have to think about it. |
|
Note PR Review SkippedPR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file. 📄Files skipped in review
💡Tips to use Matter AICommand List
|
3 participants
Description
Motivation
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Related Issues