fix: upgrade @hono/node-server to fix Node.js v24 crash#1605
fix: upgrade @hono/node-server to fix Node.js v24 crash#1605fede-kamel wants to merge 1 commit intoPortkey-AI:mainfrom
Conversation
|
@VisargD @narengogi Verified the fix on Node.js v24.10.0: Build + server boot: Unit tests (29/29 pass): The 6 suite failures are pre-existing on TypeScript: same 2 pre-existing errors on Before (Node v24 + @hono/node-server@1.13.5): After (Node v24 + @hono/node-server@1.19.14): This is a one-line version bump — minimal risk, high impact for anyone developing on Node v24. |
|
Friendly ping — this PR has been open for ~10 days without a review. Happy to address feedback or rebase further if needed. Let me know if there's anything I can clarify. Thanks! |
|
@fede-kamel please sign your commits |
199563d to
0417093
Compare
Bump @hono/node-server from ^1.3.3 (resolved 1.13.5) to ^1.14.2 (resolved 1.19.14) to fix "Failed to find Response internal state key" error on Node.js v24. Root cause: Node v24 ships a newer Undici that changed how Response internal state is accessed. Fixed upstream in honojs/node-server#241, released in @hono/node-server@1.14.2. Closes Portkey-AI#1604
0417093 to
8079ef7
Compare
|
Hi @narengogi — thanks for the review! Force-pushed
The workflow run is currently sitting in |
Closes #1604
Summary
@hono/node-serverfrom^1.3.3(resolved 1.13.5) to^1.14.2(resolved 1.19.14)Failed to find Response internal state keyerror on Node.js v24package.json+ lockfile updateRoot Cause
Node.js v24 ships a newer version of Undici that changed how
Responseinternal state is accessed (nodejs/undici@45dceeaf). This was fixed upstream in honojs/node-server#241 and released in@hono/node-server@1.14.2.Before (Node v24)
After (Node v24)
Test Plan
npm run build— cleannode start-test.js— boots without error, exits 0handlers/services/)