feat(plugins/lasso): send source.type=portkey for Used By attribution#1679
Open
orgersh92 wants to merge 1 commit into
Open
feat(plugins/lasso): send source.type=portkey for Used By attribution#1679orgersh92 wants to merge 1 commit into
orgersh92 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lasso plugin now stamps
source.type = "portkey"on every/gateway/v3/classifypayload. This drives the new "Used By" badge onthe customer's Application API Keys list — without it, all Portkey
traffic through this plugin shows as "N/A" on the keys page.
Backwards compatible:
sourceis an optional opaque object on theLasso side. Older Lasso servers ignore it.
Changes
LassoV3ClassifyRequestinterface gains an optionalsourcefield.source: { type: "portkey" }on everypayload before calling Lasso.
should send messageType PROMPT for beforeRequestHook)extended to assert the new field.