Skip to content

test: coverage gaps — flows.go untested; dictionary/named-collection/macros/plan/render_json thin; no coverage gate #99

Description

@orian

Symptom

Coverage is strong overall (~360 tests in internal/loader/hcl) but uneven:

  • cmd/hclexp/flows.go (8.2 KB) — zero tests.
  • internal/loader/hcl/macros_introspect.go — live-test only; no unit coverage.
  • internal/loader/hcl/plan.go (7.8 KB) — 1 test; render_json.go (4.8 KB) — 1 test.
  • dictionary_introspect.go (9.6 KB), dictionary_sqlgen.go (7.2 KB), named_collection_diff.go (5 KB), named_collection_dump.go, hclfuncs.go — no direct unit tests (dictionaries covered only via live tests).

CI computes total coverage but does not gate on it.

Fix direction

Add unit tests for the files above (dictionary/named-collection paths can be tested against canned create_table_query strings without a live server), then set a coverage floor in CI so it can't regress.

Found in the 2026-07-02 deep-dive audit (docs/plans/2026-07-02-deep-dive-improvement-areas.md, E2).

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions