fix(tasks): infer repository from pull request prompts (#3748)

Author: tatoalo

packages/core/src/deep-links/newTaskLinkResolver.test.ts

@@ -49,6 +49,54 @@ describe("NewTaskLinkResolver", () => {
     expect(result.analytics.properties.has_prompt).toBe(true);
   });
 
+  it.each([
+    {
+      name: "one pull request",
+      prompt:
+        '<github_pr number="12" title="Fix it" url="https://github.com/acme/web/pull/12" />',
+      expected: "acme/web",
+    },
+    {
+      name: "several pull requests from one repository",
+      prompt:
+        '<github_pr number="12" url="https://github.com/acme/web/pull/12" />\n<github_pr number="13" url="https://github.com/acme/web/pull/13" />',
+      expected: "acme/web",
+    },
+    {
+      name: "pull requests from different repositories",
+      prompt:
+        '<github_pr number="12" url="https://github.com/acme/web/pull/12" />\n<github_pr number="4" url="https://github.com/acme/api/pull/4" />',
+      expected: undefined,
+    },
+    {
+      name: "an ordinary prompt",
+      prompt: "fix the tests",
+      expected: undefined,
+    },
+  ])("infers the repository for $name", async ({ prompt, expected }) => {
+    const resolver = makeResolver(vi.fn());
+
+    const result = await resolver.resolve({ action: "new", prompt });
+
+    if (result.kind !== "navigate") throw new Error("expected navigate");
+    expect(result.navigation.initialCloudRepository).toBe(expected);
+  });
+
+  it("prefers an explicit repository over the pull request prompt", async () => {
+    const resolver = makeResolver(vi.fn());
+    const prompt =
+      '<github_pr number="12" url="https://github.com/acme/web/pull/12" />';
+
+    const result = await resolver.resolve({
+      action: "new",
+      prompt,
+      repo: "acme/api",
+    });
+
+    if (result.kind !== "navigate") throw new Error("expected navigate");
+    expect(result.navigation.initialCloudRepository).toBe("acme/api");
+  });
+
   it("uses the decoded plan as the prompt for a plan-action payload", async () => {
     const resolver = makeResolver(vi.fn());
     const payload: NewTaskLinkPayload = { action: "plan", plan: "step one" };

packages/core/src/deep-links/newTaskLinkResolver.ts

@@ -10,6 +10,34 @@ import {
 
 export { NEW_TASK_LINK_RESOLVER };
 
+const GITHUB_PR_TAG_REGEX = /<github_pr\b[^>]*\burl="([^"]+)"[^>]*\/>/g;
+
+function inferRepositoryFromPullRequests(
+  prompt: string | undefined,
+): string | undefined {
+  if (!prompt) return undefined;
+
+  const repositories = new Set<string>();
+  for (const match of prompt.matchAll(GITHUB_PR_TAG_REGEX)) {
+    try {
+      const url = new URL(match[1]);
+      const pathParts = url.pathname.split("/").filter(Boolean);
+      if (
+        url.hostname !== "github.com" ||
+        pathParts.length !== 4 ||
+        pathParts[2] !== "pull"
+      ) {
+        continue;
+      }
+      repositories.add(`${pathParts[0]}/${pathParts[1]}`);
+    } catch {}
+  }
+
+  return repositories.size === 1
+    ? repositories.values().next().value
+    : undefined;
+}
+
 @injectable()
 export class NewTaskLinkResolver {
   constructor(
@@ -35,7 +63,8 @@ export class NewTaskLinkResolver {
       kind: "navigate",
       navigation: {
         initialPrompt: payload.prompt,
-        initialCloudRepository: payload.repo,
+        initialCloudRepository:
+          payload.repo ?? inferRepositoryFromPullRequests(payload.prompt),
         initialModel: payload.model,
         initialMode: payload.mode,
       },