fix(code): fix binary file count for toolbar diff count (#2999)

## Problem

<!-- Who is this for and what problem does it solve? -->

<!-- Closes #ISSUE_ID -->

## Changes

<!-- What did you change and why? -->
<!-- If there are frontend changes, include screenshots. -->

## How did you test this?

<!-- Describe what you tested -- manual steps, automated tests, or both. -->
<!-- If you're an agent, only list tests you actually ran. -->

## Automatic notifications

- [ ] Publish to changelog?
- [ ] Alert Sales and Marketing teams?

Author: adboio

packages/git/src/queries.test.ts

@@ -4,6 +4,8 @@ import path from "node:path";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { createGitClient } from "./client";
 import {
+  type ChangedFileInfo,
+  computeDiffStatsFromFiles,
   detectDefaultBranch,
   getAllBranches,
   getBranchDiffPatchesByPath,
@@ -314,6 +316,59 @@ describe("getChangedFilesDetailed > untracked line counts", () => {
       linesAdded: LINE_COUNT_LARGER_THAN_READ_STREAM_CHUNK,
     });
   });
+
+  // Regression for #2983 follow-up: an untracked binary file (png, mp4, …)
+  // must not have its newline bytes counted as added lines. Pre-fix this
+  // surfaced as an inflated diff badge (e.g. +8147) after dropping in a
+  // screenshot or screen recording.
+  it.each([["shot.png"], ["clip.mp4"]])(
+    "reports no line count for untracked binary file %s",
+    async (name) => {
+      repoDir = await setupRepo();
+      // Content packed with newline bytes — what the line counter would have
+      // tallied if it didn't skip binary files.
+      await writeFile(path.join(repoDir, name), "\n".repeat(8147));
+
+      const files = await getChangedFilesDetailed(repoDir);
+      const binary = files.find((f) => f.path === name);
+
+      expect(binary).toMatchObject({ status: "untracked" });
+      expect(binary?.linesAdded).toBeUndefined();
+      expect(binary?.linesRemoved).toBeUndefined();
+    },
+  );
+});
+
+describe("computeDiffStatsFromFiles", () => {
+  it("excludes binary files from line totals but still counts them as changed", () => {
+    const files: ChangedFileInfo[] = [
+      {
+        path: "src/app.ts",
+        status: "modified",
+        linesAdded: 10,
+        linesRemoved: 4,
+      },
+      // Binary line counts are meaningless newline-byte tallies — exclude them.
+      {
+        path: "assets/shot.png",
+        status: "untracked",
+        linesAdded: 8147,
+        linesRemoved: 0,
+      },
+      {
+        path: "assets/clip.mp4",
+        status: "untracked",
+        linesAdded: 5000,
+        linesRemoved: 0,
+      },
+    ];
+
+    expect(computeDiffStatsFromFiles(files)).toEqual({
+      filesChanged: 3,
+      linesAdded: 10,
+      linesRemoved: 4,
+    });
+  });
 });
 
 describe("getAllBranches", () => {

packages/git/src/queries.ts

@@ -1,6 +1,7 @@
 import { createReadStream } from "node:fs";
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
+import { isBinaryFile } from "@posthog/shared";
 import type { CreateGitClientOptions } from "./client";
 import { mapWithConcurrency } from "./concurrency";
 import { getGitOperationManager } from "./operation-manager";
@@ -655,6 +656,10 @@ export async function getChangedFilesDetailed(
           if (excludePatterns && matchesExcludePattern(file, excludePatterns)) {
             continue;
           }
+          if (isBinaryFile(file)) {
+            files.push({ path: file, status: "untracked" });
+            continue;
+          }
           untrackedToCount.push(file);
         }
 
@@ -826,9 +831,10 @@ export function computeDiffStatsFromFiles(files: ChangedFileInfo[]): DiffStats {
   const uniquePaths = new Set<string>();
 
   for (const file of files) {
+    uniquePaths.add(file.path);
+    if (isBinaryFile(file.path)) continue;
     linesAdded += file.linesAdded ?? 0;
     linesRemoved += file.linesRemoved ?? 0;
-    uniquePaths.add(file.path);
   }
 
   return {