chore: address review comments

Author: fercgomes

packages/ui/src/hooks/useUserPresence.test.ts

@@ -82,6 +82,21 @@ describe("useUserPresence", () => {
     expect(result.current).toBe(false);
   });
 
+  it("stays present under a sub-throttle idle threshold while interacting", () => {
+    // idleMs below the 15s activity throttle: the throttle must scale down or
+    // active input would be dropped and the user pinned "away".
+    const { result } = renderHook(() => useUserPresence(10_000));
+
+    act(() => {
+      for (let i = 0; i < 20; i++) {
+        vi.advanceTimersByTime(4_000);
+        window.dispatchEvent(new Event("keydown"));
+      }
+    });
+
+    expect(result.current).toBe(true);
+  });
+
   it("removes listeners on unmount", () => {
     const removeSpy = vi.spyOn(window, "removeEventListener");
     const { unmount } = renderHook(() => useUserPresence());
@@ -90,7 +105,13 @@ describe("useUserPresence", () => {
 
     const removed = removeSpy.mock.calls.map(([event]) => event);
     expect(removed).toEqual(
-      expect.arrayContaining(["pointerdown", "keydown", "wheel", "focus"]),
+      expect.arrayContaining([
+        "pointerdown",
+        "pointermove",
+        "keydown",
+        "wheel",
+        "focus",
+      ]),
     );
   });
 });

packages/ui/src/hooks/useUserPresence.ts

@@ -46,11 +46,15 @@ export function useUserPresence(
   useEffect(() => {
     let lastActivityAt = Date.now();
     let lastRecordedAt = lastActivityAt;
+    // Scale the throttle down for small idleMs (test knobs): a fixed 15s
+    // throttle with idleMs <= 15s would drop every input and pin the user
+    // "away" while they actively interact.
+    const throttleMs = Math.min(ACTIVITY_THROTTLE_MS, idleMs / 4);
 
     const onActivity = (event: Event) => {
       if (event.type !== "focus" && !document.hasFocus()) return;
       const now = Date.now();
-      if (now - lastRecordedAt < ACTIVITY_THROTTLE_MS) return;
+      if (now - lastRecordedAt < throttleMs) return;
       lastRecordedAt = now;
       lastActivityAt = now;
       setPresent(true);

scripts/bench-memory-run.mjs

@@ -15,21 +15,33 @@
  * Usage:
  *   node scripts/bench-memory-run.mjs [--port 9223] [--messages 2]
  *     [--label <label>] [--out results.jsonl] [--idle-only]
+ *     [--scenario thread|switch|longout]
+ *     [--thread-task-id <id>] [--thread-title <title>]
  *
  * Prints a JSON report; final line is `TOTAL_RSS_MB=<post-workflow median>`
  * (idle median with --idle-only) for predicate extraction via `tail -1`.
  *
  * NOTE: workflow turns hit the real agent backend with trivial prompts
  * ("reply with exactly <token>") to keep token cost minimal while exercising
  * the real agent-session memory path.
+ *
+ * IMPORTANT: the `thread` and `longout` scenarios send turns into a dedicated
+ * throwaway task so benchmark chatter never lands in real work. The default
+ * --thread-task-id/--thread-title point at the original author's local bench
+ * task — in any other environment, create a scratch task once and pass its id
+ * and title explicitly, or the run aborts with "refusing to send benchmark
+ * turns".
  */
 
 import { execFileSync, spawn } from "node:child_process";
 import { appendFileSync } from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 
-const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const repoRoot = path.resolve(
+  path.dirname(fileURLToPath(import.meta.url)),
+  "..",
+);
 
 const args = process.argv.slice(2);
 function arg(name, fallback) {
@@ -144,7 +156,8 @@ async function openBenchTask(page) {
     .catch(() => "");
   if (!header?.includes(title)) {
     throw new Error(
-      `refusing to send benchmark turns: open task is "${header}", expected "${title}"`,
+      `refusing to send benchmark turns: open task is "${header}", expected "${title}". ` +
+        `Create a throwaway task in your environment and pass --thread-task-id/--thread-title.`,
     );
   }
 }

scripts/bench-memory.mjs

@@ -122,7 +122,9 @@ async function rendererHeapMb() {
       signal: AbortSignal.timeout(2000),
     });
     const targets = await res.json();
-    const page = targets.find((t) => t.type === "page" && t.webSocketDebuggerUrl);
+    const page = targets.find(
+      (t) => t.type === "page" && t.webSocketDebuggerUrl,
+    );
     if (!page) return null;
     const ws = new WebSocket(page.webSocketDebuggerUrl);
     const heap = await new Promise((resolve) => {
@@ -162,9 +164,7 @@ function median(values) {
   if (!values.length) return 0;
   const sorted = [...values].sort((a, b) => a - b);
   const mid = Math.floor(sorted.length / 2);
-  return sorted.length % 2
-    ? sorted[mid]
-    : (sorted[mid - 1] + sorted[mid]) / 2;
+  return sorted.length % 2 ? sorted[mid] : (sorted[mid - 1] + sorted[mid]) / 2;
 }
 
 const rootPid = rootPidFromCdpPort();
@@ -198,7 +198,8 @@ const heapSamples = samples.map((s) => s.heapMb).filter((h) => h != null);
 const categories = {};
 for (const s of samples) {
   for (const [k, v] of Object.entries(s.byCategoryMb)) {
-    (categories[k] ??= []).push(v);
+    categories[k] ??= [];
+    categories[k].push(v);
   }
 }