Remove suggestion simulation harness

Author: szymeo

apps/code/src/renderer/features/setup/hooks/useSetupDiscovery.ts

@@ -5,14 +5,6 @@ import { RENDERER_TOKENS } from "@renderer/di/tokens";
 import { useActiveRepoStore } from "@stores/activeRepoStore";
 import { useEffect } from "react";
 
-const SIMULATE_SUGGESTIONS_STORAGE_KEY = "posthog-code:simulate-suggestions";
-
-function shouldSimulateSuggestions(): boolean {
-  if (!import.meta.env.DEV) return false;
-  if (import.meta.env.VITE_SIMULATE_SUGGESTIONS === "1") return true;
-  return window.localStorage.getItem(SIMULATE_SUGGESTIONS_STORAGE_KEY) === "1";
-}
-
 export function useSetupDiscovery() {
   const selectedDirectory = useActiveRepoStore((s) => s.path);
 
@@ -22,17 +14,8 @@ export function useSetupDiscovery() {
   // Enricher runs per repo on every selection (gated on per-repo status
   // inside the service).
   useEffect(() => {
-    if (!selectedDirectory) return undefined;
+    if (!selectedDirectory) return;
     const service = get<SetupRunService>(RENDERER_TOKENS.SetupRunService);
-    if (shouldSimulateSuggestions()) {
-      service.startSuggestionSimulation(
-        selectedDirectory,
-        shouldSimulateSuggestions,
-      );
-      return () => service.stopSuggestionSimulation(selectedDirectory);
-    }
-
-    service.stopSuggestionSimulation();
     const discoveryEverStarted = Object.values(
       useSetupStore.getState().discoveryByRepo,
     ).some((d) => d.status !== "idle");
@@ -41,6 +24,5 @@ export function useSetupDiscovery() {
     } else {
       service.startSetup(selectedDirectory);
     }
-    return undefined;
   }, [selectedDirectory]);
 }

apps/code/src/renderer/features/setup/services/setupRunService.ts

@@ -28,43 +28,6 @@ const log = logger.scope("setup-run-service");
 
 let activityIdCounter = 0;
 
-const SIMULATED_SUGGESTION_CATEGORIES: DiscoveredTask["category"][] = [
-  "bug",
-  "performance",
-  "dead_code",
-  "duplication",
-  "event_tracking",
-  "experiment",
-];
-
-const SIMULATED_SUGGESTION_INTERVAL_MS = 2500;
-const SIMULATED_SUGGESTION_LIMIT = 12;
-
-function buildSimulatedSuggestion(
-  repoPath: string,
-  index: number,
-): DiscoveredTask {
-  const category =
-    SIMULATED_SUGGESTION_CATEGORIES[
-      index % SIMULATED_SUGGESTION_CATEGORIES.length
-    ];
-
-  return {
-    id: `simulated-suggestion-${index}`,
-    source: "agent",
-    repoPath,
-    category,
-    title: `Simulated suggestion ${index + 1}`,
-    description:
-      "A generated setup suggestion for exercising empty-state layout stability while new content keeps arriving.",
-    impact:
-      "This is dev-only test data for checking whether the composer and suggestion rows stay anchored during incremental updates.",
-    recommendation:
-      "Use this simulation to hover and click suggestions while the list keeps changing underneath the same UI surface.",
-    prompt: `Investigate simulated suggestion ${index + 1}`,
-  };
-}
-
 function extractPathFromRawInput(
   tool: string,
   rawInput: Record<string, unknown> | undefined,
@@ -273,9 +236,6 @@ export class SetupRunService {
   private anyDiscoveryEverLaunched = false;
   private discoveryStartingByRepo = new Set<string>();
   private enricherSuggestionsRunningByRepo = new Set<string>();
-  private simulatedSuggestionsRepo: string | null = null;
-  private simulatedSuggestionsTimer: number | null = null;
-  private simulatedSuggestionsCount = 0;
 
   startSetup(directory: string): void {
     // Defense in depth: never auto-run from a non-idle persisted state.
@@ -296,54 +256,6 @@ export class SetupRunService {
     this.injectEnricherSuggestions(directory);
   }
 
-  startSuggestionSimulation(
-    directory: string,
-    shouldContinue: () => boolean = () => true,
-  ): void {
-    if (!directory) return;
-    if (this.simulatedSuggestionsRepo === directory) return;
-
-    if (this.simulatedSuggestionsTimer !== null) {
-      window.clearInterval(this.simulatedSuggestionsTimer);
-    }
-
-    this.simulatedSuggestionsRepo = directory;
-    this.simulatedSuggestionsCount = 0;
-
-    const addNextSuggestion = () => {
-      if (
-        !shouldContinue() ||
-        this.simulatedSuggestionsCount >= SIMULATED_SUGGESTION_LIMIT
-      ) {
-        this.stopSuggestionSimulation(directory);
-        return;
-      }
-
-      useSetupStore
-        .getState()
-        .addDiscoveredTaskIfMissing(
-          buildSimulatedSuggestion(directory, this.simulatedSuggestionsCount),
-        );
-      this.simulatedSuggestionsCount += 1;
-    };
-
-    addNextSuggestion();
-    this.simulatedSuggestionsTimer = window.setInterval(
-      addNextSuggestion,
-      SIMULATED_SUGGESTION_INTERVAL_MS,
-    );
-  }
-
-  stopSuggestionSimulation(directory?: string): void {
-    if (directory && this.simulatedSuggestionsRepo !== directory) return;
-    if (this.simulatedSuggestionsTimer !== null) {
-      window.clearInterval(this.simulatedSuggestionsTimer);
-    }
-    this.simulatedSuggestionsTimer = null;
-    this.simulatedSuggestionsRepo = null;
-    this.simulatedSuggestionsCount = 0;
-  }
-
   startDiscovery(directory: string): void {
     if (!directory) return;
     if (this.anyDiscoveryEverLaunched) return;

apps/code/src/renderer/features/setup/stores/setupStore.ts

@@ -65,7 +65,6 @@ interface SetupStoreActions {
   completeEnrichment: (repoPath: string) => void;
   failEnrichment: (repoPath: string) => void;
   removeDiscoveredTask: (taskId: string, repoPath: string | null) => void;
-  addDiscoveredTaskIfMissing: (task: DiscoveredTask) => void;
   addEnricherSuggestionIfMissing: (task: DiscoveredTask) => void;
   pushDiscoveryActivity: (repoPath: string, entry: ActivityEntry) => void;
   resetSetup: () => void;
@@ -264,21 +263,6 @@ export const useSetupStore = create<SetupStore>()(
         }));
       },
 
-      addDiscoveredTaskIfMissing: (task) => {
-        set((state) => {
-          if (
-            state.discoveredTasks.some(
-              (t) => t.id === task.id && t.repoPath === task.repoPath,
-            )
-          ) {
-            return state;
-          }
-          return {
-            discoveredTasks: [...state.discoveredTasks, task],
-          };
-        });
-      },
-
       // Adds an enricher-source suggestion if there isn't already one with
       // the same id+repoPath. Idempotent — safe to call repeatedly on every
       // detection run. Dismissed suggestions stay dismissed until `resetSetup`.

apps/code/src/vite-env.d.ts

@@ -11,7 +11,6 @@ interface ImportMetaEnv {
   readonly VITE_POSTHOG_API_KEY?: string;
   readonly VITE_POSTHOG_API_HOST?: string;
   readonly VITE_POSTHOG_UI_HOST?: string;
-  readonly VITE_SIMULATE_SUGGESTIONS?: string;
 }
 
 interface ImportMeta {