Share inbox and automation presentation semantics

richardsolomou · richardsolomou · commit 1786032a3a35 · 2026-07-23T16:12:39.000+03:00
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
diff --git a/apps/mobile/src/app/(tabs)/inbox.tsx b/apps/mobile/src/app/(tabs)/inbox.tsx
@@ -1,3 +1,4 @@
+import { buildInboxViewedProperties } from "@posthog/core/inbox/engagement";
 import { INBOX_PIPELINE_STATUSES } from "@posthog/core/inbox/reportFiltering";
 import type { SignalReport } from "@posthog/shared/domain-types";
 import { useFocusEffect, useRouter } from "expo-router";
@@ -24,7 +25,6 @@ import {
 } from "@/features/inbox/stores/dismissedReportsStore";
 import { useInboxFilterStore } from "@/features/inbox/stores/inboxFilterStore";
 import { useInboxStore } from "@/features/inbox/stores/inboxStore";
-import { buildInboxViewedProperties } from "@/features/inbox/utils";
 import { useIntegrations } from "@/features/tasks/hooks/useIntegrations";
 import { ANALYTICS_EVENTS, useAnalytics } from "@/lib/analytics";
 
@@ -67,12 +67,16 @@ export default function InboxScreen() {
     viewedFiredForFocusRef.current = focusVersion;
     analytics.track(
       ANALYTICS_EVENTS.INBOX_VIEWED,
-      buildInboxViewedProperties(reports, totalCount, {
-        sourceProductFilter,
-        statusFilter,
-        suggestedReviewerFilter,
-        priorityFilter,
-        defaultStatusFilter: INBOX_PIPELINE_STATUSES,
+      buildInboxViewedProperties({
+        visibleReports: reports,
+        totalCount,
+        filters: {
+          sourceProductFilter,
+          statusFilter,
+          suggestedReviewerFilter,
+          priorityFilter,
+          defaultStatusFilter: INBOX_PIPELINE_STATUSES,
+        },
       }),
     );
   }, [
diff --git a/apps/mobile/src/app/automation/[id].tsx b/apps/mobile/src/app/automation/[id].tsx
@@ -1,5 +1,6 @@
 import { Text } from "@components/text";
 import { TaskAutomationValidationError } from "@posthog/api-client/posthog-client";
+import { parseSkillTemplateId } from "@posthog/core/automations/automationTemplatePresentation";
 import { Stack, useLocalSearchParams, useRouter } from "expo-router";
 import { useState } from "react";
 import {
@@ -20,7 +21,6 @@ import {
   useUpdateTaskAutomation,
 } from "@/features/tasks/hooks/useAutomations";
 import { useTask } from "@/features/tasks/hooks/useTasks";
-import { parseSkillTemplateId } from "@/features/tasks/skills/skillTemplateIds";
 import { useThemeColors } from "@/lib/theme";
 
 export default function AutomationDetailScreen() {
diff --git a/apps/mobile/src/app/automation/create.tsx b/apps/mobile/src/app/automation/create.tsx
@@ -1,4 +1,5 @@
 import { TaskAutomationValidationError } from "@posthog/api-client/posthog-client";
+import { formatSkillTemplateId } from "@posthog/core/automations/automationTemplatePresentation";
 import { getCalendars } from "expo-localization";
 import { Stack, useLocalSearchParams, useRouter } from "expo-router";
 import { useMemo, useRef, useState } from "react";
@@ -14,7 +15,6 @@ import { Text } from "@/components/text";
 import { AutomationForm } from "@/features/tasks/components/AutomationForm";
 import { useCreateTaskAutomation } from "@/features/tasks/hooks/useAutomations";
 import { useSkillStoreSkill } from "@/features/tasks/skills/hooks";
-import { formatSkillTemplateId } from "@/features/tasks/skills/skillTemplateIds";
 import { useScreenInsets } from "@/hooks/useScreenInsets";
 import { useThemeColors } from "@/lib/theme";
 
diff --git a/apps/mobile/src/features/inbox/components/ArchivedReportList.tsx b/apps/mobile/src/features/inbox/components/ArchivedReportList.tsx
@@ -1,4 +1,5 @@
 import { Text } from "@components/text";
+import { isRestorableReport } from "@posthog/core/inbox/reportMembership";
 import { inboxStatusLabel } from "@posthog/core/inbox/reportPresentation";
 import { dismissalReasonLabel } from "@posthog/shared";
 import type { SignalReport } from "@posthog/shared/domain-types";
@@ -14,7 +15,7 @@ import {
 } from "react-native";
 import { useThemeColors } from "@/lib/theme";
 import { useArchivedReports, useRestoreReport } from "../hooks/useInboxReports";
-import { formatReportTimestamp, isRestorableReport } from "../utils";
+import { formatReportTimestamp } from "../utils";
 
 interface ArchivedReportListProps {
   onReportPress?: (report: SignalReport) => void;
diff --git a/apps/mobile/src/features/inbox/hooks/useInboxReports.ts b/apps/mobile/src/features/inbox/hooks/useInboxReports.ts
@@ -7,6 +7,7 @@ import {
   INBOX_DISMISSED_STATUS_FILTER,
   INBOX_REFETCH_INTERVAL_MS,
 } from "@posthog/core/inbox/reportFiltering";
+import { isRestorableReport } from "@posthog/core/inbox/reportMembership";
 import type { DismissalReasonOptionValue } from "@posthog/shared";
 import type {
   AvailableSuggestedReviewersResponse,
@@ -31,7 +32,6 @@ import { useMemo } from "react";
 import { useAuthStore } from "@/features/auth";
 import { getPostHogApiClient } from "@/lib/posthogApiClient";
 import { useInboxFilterStore } from "../stores/inboxFilterStore";
-import { isRestorableReport } from "../utils";
 
 export const inboxKeys = {
   all: ["inbox", "signal-reports"] as const,
diff --git a/apps/mobile/src/features/inbox/utils.test.ts b/apps/mobile/src/features/inbox/utils.test.ts
@@ -1,9 +1,11 @@
+import { buildInboxViewedProperties } from "@posthog/core/inbox/engagement";
 import {
   buildArchiveListOrdering,
   buildPriorityFilterParam,
   buildSignalReportListOrdering,
   INBOX_PIPELINE_STATUSES,
 } from "@posthog/core/inbox/reportFiltering";
+import { isRestorableReport } from "@posthog/core/inbox/reportMembership";
 import { formatSignalReportSummaryMarkdown } from "@posthog/core/inbox/reportPresentation";
 import { dismissalReasonLabel } from "@posthog/shared";
 import type {
@@ -12,7 +14,24 @@ import type {
   SignalReportStatus,
 } from "@posthog/shared/domain-types";
 import { describe, expect, it } from "vitest";
-import { buildInboxViewedProperties, isRestorableReport } from "./utils";
+
+function buildMobileInboxViewedProperties(
+  reports: SignalReport[],
+  totalCount: number,
+  filters: {
+    sourceProductFilter: string[];
+    statusFilter: readonly SignalReportStatus[];
+    suggestedReviewerFilter: string[];
+    priorityFilter: string[];
+    defaultStatusFilter: readonly SignalReportStatus[];
+  },
+) {
+  return buildInboxViewedProperties({
+    visibleReports: reports,
+    totalCount,
+    filters,
+  });
+}
 
 function makeReport(
   partial: Partial<SignalReport> & Pick<SignalReport, "id">,
@@ -70,7 +89,7 @@ describe("formatSignalReportSummaryMarkdown", () => {
 
 describe("buildInboxViewedProperties", () => {
   it("emits zero counts for an empty list", () => {
-    const props = buildInboxViewedProperties([], 0, {
+    const props = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: [],
       statusFilter: INBOX_PIPELINE_STATUSES,
       suggestedReviewerFilter: [],
@@ -119,7 +138,7 @@ describe("buildInboxViewedProperties", () => {
       makeReport({ id: "4", status: "failed" }),
     ];
 
-    const props = buildInboxViewedProperties(reports, 4, {
+    const props = buildMobileInboxViewedProperties(reports, 4, {
       sourceProductFilter: [],
       statusFilter: INBOX_PIPELINE_STATUSES,
       suggestedReviewerFilter: [],
@@ -140,7 +159,7 @@ describe("buildInboxViewedProperties", () => {
   });
 
   it("marks filters active when any of status/source/reviewer/priority differs from defaults", () => {
-    const narrowed = buildInboxViewedProperties([], 0, {
+    const narrowed = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: [],
       statusFilter: ["ready"],
       suggestedReviewerFilter: [],
@@ -150,7 +169,7 @@ describe("buildInboxViewedProperties", () => {
     expect(narrowed.has_active_filters).toBe(true);
     expect(narrowed.status_filter_count).toBe(1);
 
-    const sourced = buildInboxViewedProperties([], 0, {
+    const sourced = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: ["error_tracking"],
       statusFilter: INBOX_PIPELINE_STATUSES,
       suggestedReviewerFilter: [],
@@ -160,7 +179,7 @@ describe("buildInboxViewedProperties", () => {
     expect(sourced.has_active_filters).toBe(true);
     expect(sourced.source_product_filter).toEqual(["error_tracking"]);
 
-    const reviewer = buildInboxViewedProperties([], 0, {
+    const reviewer = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: [],
       statusFilter: INBOX_PIPELINE_STATUSES,
       suggestedReviewerFilter: ["uuid-1"],
@@ -169,7 +188,7 @@ describe("buildInboxViewedProperties", () => {
     });
     expect(reviewer.has_active_filters).toBe(true);
 
-    const prioritized = buildInboxViewedProperties([], 0, {
+    const prioritized = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: [],
       statusFilter: INBOX_PIPELINE_STATUSES,
       suggestedReviewerFilter: [],
@@ -180,7 +199,7 @@ describe("buildInboxViewedProperties", () => {
   });
 
   it("treats a reordered default status set as not filtered", () => {
-    const props = buildInboxViewedProperties([], 0, {
+    const props = buildMobileInboxViewedProperties([], 0, {
       sourceProductFilter: [],
       statusFilter: [...INBOX_PIPELINE_STATUSES].reverse(),
       suggestedReviewerFilter: [],
diff --git a/apps/mobile/src/features/inbox/utils.ts b/apps/mobile/src/features/inbox/utils.ts
@@ -1,124 +1,8 @@
-import type {
-  SignalReport,
-  SignalReportPriority,
-  SignalReportStatus,
-} from "@posthog/shared/domain-types";
 import { differenceInHours, format, formatDistanceToNow } from "date-fns";
-import type { InboxViewedProperties } from "@/lib/analytics";
 
 /** Relative time for the last day, absolute "MMM d" beyond it. */
 export function formatReportTimestamp(date: Date): string {
   return differenceInHours(new Date(), date) < 24
     ? formatDistanceToNow(date, { addSuffix: true })
     : format(date, "MMM d");
 }
-
-/**
- * Archive membership: `suppressed` (user-archived) and `resolved` (PR merged).
- * Only `suppressed` is restorable; `resolved` is terminal, shown for reference.
- */
-export function isRestorableReport(
-  report: Pick<SignalReport, "status">,
-): boolean {
-  return report.status === "suppressed";
-}
-
-/**
- * Returns only reports that are actionable for the tinder-like card deck:
- * ready, immediately actionable, not already addressed.
- */
-export function getActionableReports(reports: SignalReport[]): SignalReport[] {
-  return reports.filter(
-    (r) =>
-      r.status === "ready" &&
-      r.actionability === "immediately_actionable" &&
-      !r.already_addressed,
-  );
-}
-
-interface InboxViewedFilterState {
-  sourceProductFilter: string[];
-  statusFilter: readonly SignalReportStatus[];
-  suggestedReviewerFilter: string[];
-  priorityFilter: SignalReportPriority[];
-  /** Default status filter as defined in the filter store, used to detect whether the user has narrowed it. */
-  defaultStatusFilter: readonly SignalReportStatus[];
-}
-
-/**
- * Build the property payload for the `Inbox viewed` analytics event.
- *
- * Mirrors packages/ui/src/features/inbox/components/InboxSignalsTab.tsx so
- * desktop and mobile send the same shape into PostHog.
- */
-export function buildInboxViewedProperties(
-  reports: SignalReport[],
-  totalCount: number,
-  filters: InboxViewedFilterState,
-): InboxViewedProperties {
-  const priorityCounts = {
-    P0: 0,
-    P1: 0,
-    P2: 0,
-    P3: 0,
-    P4: 0,
-    unknown: 0,
-  };
-  const actionabilityCounts = {
-    immediately_actionable: 0,
-    requires_human_input: 0,
-    not_actionable: 0,
-    unknown: 0,
-  };
-  let readyCount = 0;
-  for (const r of reports) {
-    if (r.status === "ready") readyCount += 1;
-    const p = r.priority;
-    if (p === "P0" || p === "P1" || p === "P2" || p === "P3" || p === "P4") {
-      priorityCounts[p] += 1;
-    } else {
-      priorityCounts.unknown += 1;
-    }
-    const a = r.actionability;
-    if (
-      a === "immediately_actionable" ||
-      a === "requires_human_input" ||
-      a === "not_actionable"
-    ) {
-      actionabilityCounts[a] += 1;
-    } else {
-      actionabilityCounts.unknown += 1;
-    }
-  }
-
-  const statusFiltered =
-    filters.statusFilter.length !== filters.defaultStatusFilter.length ||
-    filters.statusFilter.some((s) => !filters.defaultStatusFilter.includes(s));
-  const hasActiveFilters =
-    statusFiltered ||
-    filters.sourceProductFilter.length > 0 ||
-    filters.suggestedReviewerFilter.length > 0 ||
-    filters.priorityFilter.length > 0;
-
-  return {
-    report_count: reports.length,
-    total_count: totalCount,
-    ready_count: readyCount,
-    has_active_filters: hasActiveFilters,
-    source_product_filter: filters.sourceProductFilter,
-    status_filter_count: filters.statusFilter.length,
-    is_empty: totalCount === 0,
-    priority_p0_count: priorityCounts.P0,
-    priority_p1_count: priorityCounts.P1,
-    priority_p2_count: priorityCounts.P2,
-    priority_p3_count: priorityCounts.P3,
-    priority_p4_count: priorityCounts.P4,
-    priority_unknown_count: priorityCounts.unknown,
-    actionability_immediately_actionable_count:
-      actionabilityCounts.immediately_actionable,
-    actionability_requires_human_input_count:
-      actionabilityCounts.requires_human_input,
-    actionability_not_actionable_count: actionabilityCounts.not_actionable,
-    actionability_unknown_count: actionabilityCounts.unknown,
-  };
-}
diff --git a/apps/mobile/src/features/tasks/components/AutomationDetail.tsx b/apps/mobile/src/features/tasks/components/AutomationDetail.tsx
@@ -1,9 +1,9 @@
 import { Text } from "@components/text";
 import type { TaskAutomation } from "@posthog/api-client/posthog-client";
 import { formatAutomationScheduleSummary } from "@posthog/core/automations/automationSchedule";
+import { getAutomationTemplatePresentation } from "@posthog/core/automations/automationTemplatePresentation";
 import type { TaskRun } from "@posthog/shared";
 import { ActivityIndicator, Pressable, View } from "react-native";
-import { getAutomationTemplatePresentation } from "../utils/automationTemplatePresentation";
 import { AutomationStatusBadge } from "./AutomationStatusBadge";
 
 interface AutomationDetailProps {
diff --git a/apps/mobile/src/features/tasks/components/AutomationItem.tsx b/apps/mobile/src/features/tasks/components/AutomationItem.tsx
@@ -1,11 +1,11 @@
 import { Text } from "@components/text";
 import type { TaskAutomation } from "@posthog/api-client/posthog-client";
 import { formatAutomationScheduleSummary } from "@posthog/core/automations/automationSchedule";
+import { getAutomationTemplatePresentation } from "@posthog/core/automations/automationTemplatePresentation";
 import type { TaskRun } from "@posthog/shared";
 import { format, formatDistanceToNow } from "date-fns";
 import { memo } from "react";
 import { Pressable, View } from "react-native";
-import { getAutomationTemplatePresentation } from "../utils/automationTemplatePresentation";
 import { AutomationStatusBadge } from "./AutomationStatusBadge";
 
 interface AutomationItemProps {
diff --git a/apps/mobile/src/features/tasks/skills/skillTemplateIds.ts b/apps/mobile/src/features/tasks/skills/skillTemplateIds.ts
diff --git a/apps/mobile/src/features/tasks/utils/automationTemplatePresentation.test.ts b/apps/mobile/src/features/tasks/utils/automationTemplatePresentation.test.ts
@@ -1,5 +1,5 @@
+import { getAutomationTemplatePresentation } from "@posthog/core/automations/automationTemplatePresentation";
 import { describe, expect, it } from "vitest";
-import { getAutomationTemplatePresentation } from "./automationTemplatePresentation";
 
 describe("automationTemplatePresentation", () => {
   it("prefers repository context when one exists for skill-backed automations", () => {
diff --git a/packages/core/src/automations/automationTemplatePresentation.ts b/packages/core/src/automations/automationTemplatePresentation.ts
@@ -1,5 +1,18 @@
 import type { TaskAutomation } from "@posthog/api-client/posthog-client";
-import { parseSkillTemplateId } from "../skills/skillTemplateIds";
+
+export const SKILL_TEMPLATE_ID_PREFIX = "llm-skill:";
+
+export function formatSkillTemplateId(skillName: string): string {
+  return `${SKILL_TEMPLATE_ID_PREFIX}${skillName.trim()}`;
+}
+
+export function parseSkillTemplateId(
+  templateId: string | null | undefined,
+): string | null {
+  if (!templateId?.startsWith(SKILL_TEMPLATE_ID_PREFIX)) return null;
+  const skillName = templateId.slice(SKILL_TEMPLATE_ID_PREFIX.length).trim();
+  return skillName || null;
+}
 
 export interface AutomationTemplatePresentation {
   templateName: string | null;
@@ -14,7 +27,6 @@ export function getAutomationTemplatePresentation(
   const repositoryLabel = automation.repository.trim() || null;
   const skillName = parseSkillTemplateId(automation.template_id);
   const contextLabel = skillName ? "Skill store" : null;
-
   return {
     templateName:
       skillName ?? (automation.template_id ? "Template automation" : null),
diff --git a/packages/core/src/inbox/engagement.ts b/packages/core/src/inbox/engagement.ts
diff --git a/packages/core/src/inbox/reportMembership.ts b/packages/core/src/inbox/reportMembership.ts
