Skip to content

Commit 1e969dc

Browse files
committed
pin timeout copy and align its imports
1 parent 98e2c80 commit 1e969dc

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

packages/core/src/onboarding/githubConnectPanel.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { describe, expect, it } from "vitest";
2+
import { GITHUB_CONNECT_TIMEOUT_MESSAGE } from "../integrations/connectErrors";
23
import {
34
buildConnectFailedProps,
45
buildConnectFailureFingerprint,
@@ -29,7 +30,7 @@ describe("getGithubPanelMessage", () => {
2930
};
3031
expect(
3132
getGithubPanelMessage({ ...base, timedOut: true, isConnecting: false }),
32-
).toMatch(/didn't hear back/);
33+
).toBe(GITHUB_CONNECT_TIMEOUT_MESSAGE);
3334
expect(
3435
getGithubPanelMessage({ ...base, timedOut: false, isConnecting: true }),
3536
).toBe("Waiting for GitHub...");

packages/ui/src/features/settings/sections/GitHubIntegrationSection.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import {
44
GitBranchIcon,
55
InfoIcon,
66
} from "@phosphor-icons/react";
7-
import { GITHUB_CONNECT_TIMEOUT_MESSAGE } from "@posthog/core/integrations/connectErrors";
7+
import {
8+
describeGithubConnectError,
9+
GITHUB_CONNECT_TIMEOUT_MESSAGE,
10+
} from "@posthog/core/integrations/connectErrors";
811
import { summarizeReposByOwner } from "@posthog/core/settings/githubRepoSummary";
912
import { Button } from "@posthog/quill";
1013
import { useAuthStateValue } from "@posthog/ui/features/auth/store";
11-
import {
12-
describeGithubConnectError,
13-
useGithubConnect,
14-
} from "@posthog/ui/features/integrations/useGithubUserConnect";
14+
import { useGithubConnect } from "@posthog/ui/features/integrations/useGithubUserConnect";
1515
import { useRepositoryIntegration } from "@posthog/ui/features/integrations/useIntegrations";
1616
import { Box, Flex, Spinner, Text, Tooltip } from "@radix-ui/themes";
1717
import { useMemo } from "react";

packages/ui/src/features/task-detail/components/CloudGithubMissingNotice.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { ArrowSquareOutIcon, InfoIcon } from "@phosphor-icons/react";
2-
import { GITHUB_CONNECT_TIMEOUT_MESSAGE } from "@posthog/core/integrations/connectErrors";
3-
import { useAuthStateValue } from "@posthog/ui/features/auth/store";
42
import {
53
describeGithubConnectError,
6-
useGithubConnect,
7-
} from "@posthog/ui/features/integrations/useGithubUserConnect";
4+
GITHUB_CONNECT_TIMEOUT_MESSAGE,
5+
} from "@posthog/core/integrations/connectErrors";
6+
import { useAuthStateValue } from "@posthog/ui/features/auth/store";
7+
import { useGithubConnect } from "@posthog/ui/features/integrations/useGithubUserConnect";
88
import { useRepositoryIntegration } from "@posthog/ui/features/integrations/useIntegrations";
99
import { Button, Callout, Flex, Spinner, Text } from "@radix-ui/themes";
1010

0 commit comments

Comments
 (0)