refactor(inbox): drop redundant clearPriorityFilter in favor of setPriorityFilter([])

simplify pass: setPriorityFilter([]) already expresses "clear priority to Any", so the dedicated clearPriorityFilter action was pure duplication. clearSourceProductFilter is kept since the source filter has no equivalent setter.

Generated-By: PostHog Code
Task-Id: 97aa95fe-d9a3-4651-aa9b-9f636fc84832

Author: pauldambra

packages/ui/src/features/inbox/components/InboxSearchFilterBar.tsx

@@ -45,8 +45,8 @@ export function InboxSearchFilterBar({
   );
   const priorityFilter = useInboxSignalsFilterStore((s) => s.priorityFilter);
   const togglePriority = useInboxSignalsFilterStore((s) => s.togglePriority);
-  const clearPriorityFilter = useInboxSignalsFilterStore(
-    (s) => s.clearPriorityFilter,
+  const setPriorityFilter = useInboxSignalsFilterStore(
+    (s) => s.setPriorityFilter,
   );
 
   const activeSort = INBOX_SORT_OPTIONS.find(
@@ -144,7 +144,7 @@ export function InboxSearchFilterBar({
         <Flex direction="column" gap="0">
           <InboxFilterAnyItem
             active={priorityFilter.length === 0}
-            onClick={clearPriorityFilter}
+            onClick={() => setPriorityFilter([])}
           />
           {INBOX_PRIORITY_OPTIONS.map((option) => {
             const isActive = priorityFilter.includes(option.value);

packages/ui/src/features/inbox/stores/inboxSignalsFilterStore.test.ts

@@ -71,10 +71,10 @@ describe("inboxSignalsFilterStore", () => {
     ]);
   });
 
-  it("clearPriorityFilter resets priorities back to Any (empty)", () => {
+  it("setPriorityFilter resets priorities back to Any (empty)", () => {
     useInboxSignalsFilterStore.getState().setPriorityFilter(["P0", "P1"]);
 
-    useInboxSignalsFilterStore.getState().clearPriorityFilter();
+    useInboxSignalsFilterStore.getState().setPriorityFilter([]);
 
     expect(useInboxSignalsFilterStore.getState().priorityFilter).toEqual([]);
   });

packages/ui/src/features/inbox/stores/inboxSignalsFilterStore.ts

@@ -33,8 +33,6 @@ interface InboxSignalsFilterActions {
   setPriorityFilter: (priorities: SignalReportPriority[]) => void;
   /** Clear the source filter back to "Any" (empty = all sources). */
   clearSourceProductFilter: () => void;
-  /** Clear the priority filter back to "Any" (empty = all priorities). */
-  clearPriorityFilter: () => void;
   /** Reset all filters when a deep link arrives so the linked report isn't hidden. */
   resetFilters: () => void;
 }
@@ -79,7 +77,6 @@ export const useInboxSignalsFilterStore = create<InboxSignalsFilterStore>()(
           priorityFilter: Array.from(new Set(priorities)),
         }),
       clearSourceProductFilter: () => set({ sourceProductFilter: [] }),
-      clearPriorityFilter: () => set({ priorityFilter: [] }),
       resetFilters: () =>
         set({
           searchQuery: "",