fix(sessions): preserve permission mode and effort on cloud resume (#2993)

Author: k11kirky

packages/core/src/sessions/cloudRunOptions.test.ts

@@ -84,5 +84,34 @@ describe("getCloudRuntimeOptions", () => {
     expect(result.model).toBeUndefined();
     expect(result.reasoningLevel).toBeUndefined();
     expect(result.adapter).toBeUndefined();
+    expect(result.initialPermissionMode).toBeUndefined();
+  });
+
+  it.each([
+    {
+      label: "prefers the session mode config option for permission mode",
+      configOptions: [
+        { category: "mode", currentValue: "acceptEdits" },
+        // biome-ignore lint/suspicious/noExplicitAny: minimal config option shape
+      ] as any,
+      previousRun: {
+        state: { initial_permission_mode: "plan" },
+      } as unknown as TaskRun,
+      expected: "acceptEdits",
+    },
+    {
+      label: "falls back to the previous run state for permission mode",
+      configOptions: [],
+      previousRun: {
+        state: { initial_permission_mode: "acceptEdits" },
+      } as unknown as TaskRun,
+      expected: "acceptEdits",
+    },
+  ])("$label", ({ configOptions, previousRun, expected }) => {
+    const result = getCloudRuntimeOptions(
+      session({ configOptions }),
+      previousRun,
+    );
+    expect(result.initialPermissionMode).toBe(expected);
   });
 });

packages/core/src/sessions/cloudRunOptions.ts

@@ -2,6 +2,7 @@ import {
   type Adapter,
   type AgentSession,
   type CloudRunSource,
+  type ExecutionMode,
   getConfigOptionByCategory,
   type PrAuthorshipMode,
 } from "@posthog/shared";
@@ -34,6 +35,7 @@ export interface CloudRuntimeOptions {
   adapter?: Adapter;
   model?: string;
   reasoningLevel?: string;
+  initialPermissionMode?: ExecutionMode;
 }
 
 export function getCloudRuntimeOptions(
@@ -45,6 +47,8 @@ export function getCloudRuntimeOptions(
     session.configOptions,
     "thought_level",
   );
+  const modeOption = getConfigOptionByCategory(session.configOptions, "mode");
+  const previousMode = previousRun?.state?.initial_permission_mode;
 
   return {
     adapter: session.adapter ?? previousRun?.runtime_adapter ?? undefined,
@@ -56,5 +60,11 @@ export function getCloudRuntimeOptions(
       typeof thoughtLevelOption?.currentValue === "string"
         ? thoughtLevelOption.currentValue
         : (previousRun?.reasoning_effort ?? undefined),
+    initialPermissionMode:
+      typeof modeOption?.currentValue === "string"
+        ? (modeOption.currentValue as ExecutionMode)
+        : typeof previousMode === "string"
+          ? (previousMode as ExecutionMode)
+          : undefined,
   };
 }

packages/core/src/sessions/sessionService.ts

@@ -48,6 +48,7 @@ import { classifyCloudLogAppend } from "./cloudLogGap";
 import { CloudLogGapReconciler } from "./cloudLogGapReconciler";
 import { CloudRunIdleTracker } from "./cloudRunIdleTracker";
 import {
+  type CloudRuntimeOptions,
   getCloudPrAuthorshipMode,
   getCloudRunSource,
   getCloudRuntimeOptions,
@@ -2589,6 +2590,7 @@ export class SessionService {
     };
 
     let updatedTask: Task;
+    let runtimeOptions: CloudRuntimeOptions;
     try {
       const artifactIds = await this.d.h.uploadTaskStagedAttachments(
         authCredentials.client,
@@ -2625,7 +2627,7 @@ export class SessionService {
         previousStatus: session.cloudStatus,
       });
 
-      const runtimeOptions = getCloudRuntimeOptions(session, previousRun);
+      runtimeOptions = getCloudRuntimeOptions(session, previousRun);
 
       // Backend derives the snapshot from resumeFromRunId and restores the sandbox.
       updatedTask = await authCredentials.client.runTaskInCloud(
@@ -2635,6 +2637,7 @@ export class SessionService {
           adapter: runtimeOptions.adapter,
           model: runtimeOptions.model,
           reasoningLevel: runtimeOptions.reasoningLevel,
+          initialPermissionMode: runtimeOptions.initialPermissionMode,
           resumeFromRunId: session.taskRunId,
           pendingUserMessage: transport.messageText,
           pendingUserArtifactIds:
@@ -2693,6 +2696,8 @@ export class SessionService {
     )?.currentValue;
     const initialModel =
       newRun.model ?? (typeof priorModel === "string" ? priorModel : undefined);
+    const initialReasoningEffort =
+      newRun.reasoning_effort ?? runtimeOptions.reasoningLevel;
     this.watchCloudTask(
       session.taskId,
       newRun.id,
@@ -2705,6 +2710,8 @@ export class SessionService {
       initialModel,
       undefined,
       resumeFromEntryCount,
+      undefined,
+      initialReasoningEffort,
     );
 
     this.d.queryClient.invalidateQueries({ queryKey: ["tasks"] });
@@ -3217,6 +3224,7 @@ export class SessionService {
     apiHost: string,
     adapter: Adapter,
     initialModel?: string,
+    initialReasoningEffort?: string,
   ): Promise<void> {
     const cacheKey = `${apiHost}::${adapter}`;
     let entry = this.previewConfigOptionsCache.get(cacheKey);
@@ -3260,6 +3268,16 @@ export class SessionService {
             return { ...opt, currentValue: initialModel };
           }
         }
+        if (
+          opt.category === "thought_level" &&
+          opt.type === "select" &&
+          typeof initialReasoningEffort === "string"
+        ) {
+          const flat = flattenSelectOptions(opt.options);
+          if (flat.some((o) => o.value === initialReasoningEffort)) {
+            return { ...opt, currentValue: initialReasoningEffort };
+          }
+        }
         return opt;
       });
 
@@ -3298,6 +3316,7 @@ export class SessionService {
     taskDescription?: string,
     resumeFromEntryCount?: number,
     runStatus?: TaskRunStatus,
+    initialReasoningEffort?: string,
   ): () => void {
     const taskRunId = runId;
 
@@ -3337,6 +3356,7 @@ export class SessionService {
           apiHost,
           adapter,
           initialModel,
+          initialReasoningEffort,
         );
       }
       return () => {};
@@ -3428,6 +3448,7 @@ export class SessionService {
       apiHost,
       adapter,
       initialModel,
+      initialReasoningEffort,
     );
 
     if (shouldHydrateSession) {
@@ -4104,6 +4125,8 @@ export class SessionService {
     const adapter =
       task.latest_run?.runtime_adapter === "codex" ? "codex" : "claude";
     const initialModel = task.latest_run?.model ?? undefined;
+    const initialReasoningEffort =
+      task.latest_run?.reasoning_effort ?? undefined;
 
     return this.watchCloudTask(
       task.id,
@@ -4118,6 +4141,7 @@ export class SessionService {
       task.description ?? undefined,
       undefined,
       task.latest_run?.status,
+      initialReasoningEffort,
     );
   }