fix(inbox): preserve host filter contracts

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Author: richardsolomou

apps/mobile/src/app/(tabs)/inbox.tsx

@@ -71,6 +71,7 @@ export default function InboxScreen() {
         visibleReports: reports,
         totalCount,
         filters: {
+          surface: "mobile",
           sourceProductFilter,
           statusFilter,
           suggestedReviewerFilter,

apps/mobile/src/features/inbox/utils.test.ts

@@ -29,7 +29,7 @@ function buildMobileInboxViewedProperties(
   return buildInboxViewedProperties({
     visibleReports: reports,
     totalCount,
-    filters,
+    filters: { surface: "mobile", ...filters },
   });
 }
 

packages/core/src/inbox/engagement.test.ts

@@ -28,6 +28,7 @@ function fakeReport(overrides: Partial<SignalReport> = {}): SignalReport {
 }
 
 const NO_FILTERS = {
+  surface: "desktop" as const,
   sourceProductFilter: [],
   priorityFilter: [],
   searchQuery: "",

packages/core/src/inbox/engagement.ts

@@ -170,21 +170,35 @@ export function buildBulkActionEvents(
   }));
 }
 
-export interface InboxViewedFilterState {
+interface InboxViewedFilterStateBase {
   sourceProductFilter: string[];
   priorityFilter: string[];
-  searchQuery?: string;
-  statusFilter?: readonly string[];
-  defaultStatusFilter?: readonly string[];
-  suggestedReviewerFilter?: string[];
+}
+
+export interface DesktopInboxViewedFilterState
+  extends InboxViewedFilterStateBase {
+  surface: "desktop";
+  searchQuery: string;
   /**
    * True when the reviewer scope is the default ("For you"). False when the
    * user has narrowed to a teammate or the whole project — treated as an
    * active filter for `has_active_filters`.
    */
-  isDefaultScope?: boolean;
+  isDefaultScope: boolean;
 }
 
+export interface MobileInboxViewedFilterState
+  extends InboxViewedFilterStateBase {
+  surface: "mobile";
+  statusFilter: readonly string[];
+  defaultStatusFilter: readonly string[];
+  suggestedReviewerFilter: string[];
+}
+
+export type InboxViewedFilterState =
+  | DesktopInboxViewedFilterState
+  | MobileInboxViewedFilterState;
+
 export interface BuildInboxViewedInput {
   /**
    * Reports currently visible to the user (after reviewer scope + search), used
@@ -241,27 +255,28 @@ export function buildInboxViewedProperties(
   }
 
   const statusFiltered =
-    filters.statusFilter !== undefined &&
-    filters.defaultStatusFilter !== undefined &&
+    filters.surface === "mobile" &&
     (filters.statusFilter.length !== filters.defaultStatusFilter.length ||
       filters.statusFilter.some(
-        (status) => !filters.defaultStatusFilter?.includes(status),
+        (status) => !filters.defaultStatusFilter.includes(status),
       ));
   const hasActiveFilters =
     filters.sourceProductFilter.length > 0 ||
     filters.priorityFilter.length > 0 ||
-    (filters.searchQuery?.trim().length ?? 0) > 0 ||
+    (filters.surface === "desktop" && filters.searchQuery.trim().length > 0) ||
     statusFiltered ||
-    (filters.suggestedReviewerFilter?.length ?? 0) > 0 ||
-    filters.isDefaultScope === false;
+    (filters.surface === "mobile" &&
+      filters.suggestedReviewerFilter.length > 0) ||
+    (filters.surface === "desktop" && !filters.isDefaultScope);
 
   return {
     report_count: visibleReports.length,
     total_count: totalCount,
     ready_count: readyCount,
     has_active_filters: hasActiveFilters,
     source_product_filter: filters.sourceProductFilter,
-    status_filter_count: filters.statusFilter?.length ?? 0,
+    status_filter_count:
+      filters.surface === "mobile" ? filters.statusFilter.length : 0,
     is_empty: totalCount === 0,
     priority_p0_count: priorityCounts.P0,
     priority_p1_count: priorityCounts.P1,

packages/core/src/inbox/reportMembership.ts

@@ -41,17 +41,6 @@ export function isRestorableReport(
   return report.status === "suppressed";
 }
 
-export function getImmediatelyActionableReports(
-  reports: SignalReport[],
-): SignalReport[] {
-  return reports.filter(
-    (report) =>
-      report.status === "ready" &&
-      report.actionability === "immediately_actionable" &&
-      !report.already_addressed,
-  );
-}
-
 export type InboxScope = "for-you" | "entire-project" | `teammate:${string}`;
 
 export const INBOX_SCOPE_FOR_YOU: InboxScope = "for-you";

packages/ui/src/features/inbox/hooks/useTrackInboxViewed.ts

@@ -41,6 +41,7 @@ export function useTrackInboxViewed(): void {
         totalCount,
         tabCounts: counts,
         filters: {
+          surface: "desktop",
           sourceProductFilter,
           priorityFilter,
           searchQuery,