remove constant window property and unsafe cast

Author: charlesvien

packages/shared/src/analytics-events.ts

@@ -632,7 +632,6 @@ export interface UsageViewedProperties {
   sustained_used_percent: number | null;
   /** Daily bucket percent (0-100), null when usage is unavailable. */
   burst_used_percent: number | null;
-  spend_analysis_window_days: number;
 }
 
 export interface SpendAnalysisTaskOpenedProperties {

packages/ui/src/features/usage/UsageView.tsx

@@ -2,7 +2,6 @@ import { ChartLine, CreditCard, WarningCircle } from "@phosphor-icons/react";
 import {
   fillSpendDays,
   type SpendAnalysisWindow,
-  windowToDays,
 } from "@posthog/core/billing/spendAnalysisFormat";
 import {
   Empty,
@@ -90,7 +89,6 @@ export function UsageView() {
     isPro,
     sustainedUsedPercent: usage?.sustained.used_percent ?? null,
     burstUsedPercent: usage?.burst.used_percent ?? null,
-    spendAnalysisWindowDays: windowToDays(spendWindow),
   });
 
   if (!billingEnabled && !spendAnalysisEnabled) {

packages/ui/src/features/usage/components/WindowSelector.tsx

@@ -17,7 +17,10 @@ export function WindowSelector({ value, onChange }: WindowSelectorProps) {
     <SegmentedControl.Root
       value={value}
       size="1"
-      onValueChange={(next) => onChange(next as SpendAnalysisWindow)}
+      onValueChange={(next) => {
+        const found = WINDOW_OPTIONS.find((option) => option.value === next);
+        if (found) onChange(found.value);
+      }}
       aria-label="Spend analysis window"
     >
       {WINDOW_OPTIONS.map((option) => (

packages/ui/src/features/usage/useTrackUsageViewed.ts

@@ -7,17 +7,10 @@ export interface TrackUsageViewedInput {
   isPro: boolean;
   sustainedUsedPercent: number | null;
   burstUsedPercent: number | null;
-  spendAnalysisWindowDays: number;
 }
 
 export function useTrackUsageViewed(input: TrackUsageViewedInput): void {
-  const {
-    isLoading,
-    isPro,
-    sustainedUsedPercent,
-    burstUsedPercent,
-    spendAnalysisWindowDays,
-  } = input;
+  const { isLoading, isPro, sustainedUsedPercent, burstUsedPercent } = input;
 
   const firedRef = useRef(false);
   useEffect(() => {
@@ -29,13 +22,6 @@ export function useTrackUsageViewed(input: TrackUsageViewedInput): void {
       is_pro: isPro,
       sustained_used_percent: sustainedUsedPercent,
       burst_used_percent: burstUsedPercent,
-      spend_analysis_window_days: spendAnalysisWindowDays,
     });
-  }, [
-    isLoading,
-    isPro,
-    sustainedUsedPercent,
-    burstUsedPercent,
-    spendAnalysisWindowDays,
-  ]);
+  }, [isLoading, isPro, sustainedUsedPercent, burstUsedPercent]);
 }