Fix suggestion simulation cleanup

Author: szymeo

apps/code/src/renderer/features/setup/hooks/useSetupDiscovery.ts

@@ -22,13 +22,17 @@ export function useSetupDiscovery() {
   // Enricher runs per repo on every selection (gated on per-repo status
   // inside the service).
   useEffect(() => {
-    if (!selectedDirectory) return;
+    if (!selectedDirectory) return undefined;
     const service = get<SetupRunService>(RENDERER_TOKENS.SetupRunService);
     if (shouldSimulateSuggestions()) {
-      service.startSuggestionSimulation(selectedDirectory);
-      return;
+      service.startSuggestionSimulation(
+        selectedDirectory,
+        shouldSimulateSuggestions,
+      );
+      return () => service.stopSuggestionSimulation(selectedDirectory);
     }
 
+    service.stopSuggestionSimulation();
     const discoveryEverStarted = Object.values(
       useSetupStore.getState().discoveryByRepo,
     ).some((d) => d.status !== "idle");
@@ -37,5 +41,6 @@ export function useSetupDiscovery() {
     } else {
       service.startSetup(selectedDirectory);
     }
+    return undefined;
   }, [selectedDirectory]);
 }

apps/code/src/renderer/features/setup/services/setupRunService.ts

@@ -38,6 +38,7 @@ const SIMULATED_SUGGESTION_CATEGORIES: DiscoveredTask["category"][] = [
 ];
 
 const SIMULATED_SUGGESTION_INTERVAL_MS = 2500;
+const SIMULATED_SUGGESTION_LIMIT = 12;
 
 function buildSimulatedSuggestion(
   repoPath: string,
@@ -295,7 +296,10 @@ export class SetupRunService {
     this.injectEnricherSuggestions(directory);
   }
 
-  startSuggestionSimulation(directory: string): void {
+  startSuggestionSimulation(
+    directory: string,
+    shouldContinue: () => boolean = () => true,
+  ): void {
     if (!directory) return;
     if (this.simulatedSuggestionsRepo === directory) return;
 
@@ -305,11 +309,16 @@ export class SetupRunService {
 
     this.simulatedSuggestionsRepo = directory;
     this.simulatedSuggestionsCount = 0;
-    useSetupStore
-      .getState()
-      .startDiscovery(directory, "simulated-discovery", "simulated-run");
 
     const addNextSuggestion = () => {
+      if (
+        !shouldContinue() ||
+        this.simulatedSuggestionsCount >= SIMULATED_SUGGESTION_LIMIT
+      ) {
+        this.stopSuggestionSimulation(directory);
+        return;
+      }
+
       useSetupStore
         .getState()
         .addDiscoveredTaskIfMissing(
@@ -325,6 +334,16 @@ export class SetupRunService {
     );
   }
 
+  stopSuggestionSimulation(directory?: string): void {
+    if (directory && this.simulatedSuggestionsRepo !== directory) return;
+    if (this.simulatedSuggestionsTimer !== null) {
+      window.clearInterval(this.simulatedSuggestionsTimer);
+    }
+    this.simulatedSuggestionsTimer = null;
+    this.simulatedSuggestionsRepo = null;
+    this.simulatedSuggestionsCount = 0;
+  }
+
   startDiscovery(directory: string): void {
     if (!directory) return;
     if (this.anyDiscoveryEverLaunched) return;

apps/code/src/renderer/features/task-detail/components/SuggestedTasksPanel.tsx

@@ -121,7 +121,7 @@ export function SuggestedTasksPanel() {
 
   const hasTasks = discoveredTasks.length > 0;
   const showEnricherFeed = !hasTasks && enricherStatus === "running";
-  const showDiscoveryFeed = !hasTasks && discoveryStatus === "running";
+  const showDiscoveryFeed = discoveryStatus === "running";
 
   if (!hasTasks && !showEnricherFeed && !showDiscoveryFeed) return null;