Commit 4d4b2a8
authored
Redirect resolved reports to Archive and hide their Restore action
Adding `resolved` to INBOX_EXCLUDED_STATUSES left two gaps for resolved (merged-PR) reports:
- InboxReportDetailGate's stale-URL redirect only checked `suppressed`, so a resolved report opened at a /pulls, /reports, or /runs URL rendered full triage actions instead of redirecting to Archive. Switch to the isDismissedReport predicate (suppressed OR resolved) so both terminal states redirect symmetrically.
- DismissedReportDetail always rendered Restore; resolved reports are terminal, so gate it with isResolvedReport — matching the list-card behavior.
Per Greptile review.
Generated-By: PostHog Code
Task-Id: 3a7dec81-6f1d-425a-a7cb-f468c36b3ec71 parent 70ebd35 commit 4d4b2a8
2 files changed
Lines changed: 22 additions & 17 deletions
File tree
- packages/ui/src/features/inbox/components
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | | - | |
29 | | - | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
58 | | - | |
| 60 | + | |
| 61 | + | |
59 | 62 | | |
60 | 63 | | |
61 | 64 | | |
| |||
Lines changed: 12 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
85 | 87 | | |
86 | 88 | | |
87 | | - | |
| 89 | + | |
88 | 90 | | |
89 | 91 | | |
90 | | - | |
| 92 | + | |
91 | 93 | | |
92 | | - | |
| 94 | + | |
93 | 95 | | |
94 | 96 | | |
95 | 97 | | |
| |||
0 commit comments