refactor(sessions): share attachment summary prefix, parameterise tests

Author: tatoalo

packages/core/src/editor/cloud-prompt.test.ts

@@ -64,15 +64,21 @@ describe("cloud-prompt", () => {
     );
   });
 
-  it("strips the trailing attachment summary from a task description", () => {
-    expect(
-      stripTrailingAttachmentSummary("do this\n\nAttached files: a.png, b.txt"),
-    ).toBe("do this");
-    expect(stripTrailingAttachmentSummary("Attached files: a.png")).toBe("");
-    expect(stripTrailingAttachmentSummary("do this")).toBe("do this");
-    expect(
-      stripTrailingAttachmentSummary("Attached files: a.png\n\nthen do this"),
-    ).toBe("Attached files: a.png\n\nthen do this");
+  it.each([
+    [
+      "text + trailing summary",
+      "do this\n\nAttached files: a.png, b.txt",
+      "do this",
+    ],
+    ["summary only", "Attached files: a.png", ""],
+    ["no summary", "do this", "do this"],
+    [
+      "summary not at end",
+      "Attached files: a.png\n\nthen do this",
+      "Attached files: a.png\n\nthen do this",
+    ],
+  ])("stripTrailingAttachmentSummary: %s", (_label, input, expected) => {
+    expect(stripTrailingAttachmentSummary(input)).toBe(expected);
   });
 
   it("uses resource_link path references for text attachments", async () => {

packages/core/src/editor/cloud-prompt.ts

@@ -147,7 +147,10 @@ export function getAbsoluteAttachmentPaths(
   );
 }
 
-const TRAILING_ATTACHMENT_SUMMARY_REGEX = /(?:^|\n)Attached files: [^\n]*$/;
+export const ATTACHMENT_SUMMARY_PREFIX = "Attached files: ";
+const TRAILING_ATTACHMENT_SUMMARY_REGEX = new RegExp(
+  `(?:^|\\n)${ATTACHMENT_SUMMARY_PREFIX}[^\\n]*$`,
+);
 
 export function stripTrailingAttachmentSummary(text: string): string {
   return text.replace(TRAILING_ATTACHMENT_SUMMARY_REGEX, "").trim();
@@ -166,7 +169,7 @@ export function buildCloudTaskDescription(
     return strippedPrompt;
   }
 
-  const attachmentSummary = `Attached files: ${attachmentNames.join(", ")}`;
+  const attachmentSummary = `${ATTACHMENT_SUMMARY_PREFIX}${attachmentNames.join(", ")}`;
   return strippedPrompt
     ? `${strippedPrompt}\n\n${attachmentSummary}`
     : attachmentSummary;

packages/core/src/sessions/cloudPrompt.ts

@@ -1,5 +1,6 @@
 import type { ContentBlock } from "@agentclientprotocol/sdk";
 import {
+  ATTACHMENT_SUMMARY_PREFIX,
   buildCloudTaskDescription,
   getAbsoluteAttachmentPaths,
   stripAbsoluteFileTags,
@@ -87,7 +88,7 @@ function summarizePrompt(text: string, filePaths: string[]): string {
     return text.trim();
   }
 
-  const attachmentSummary = `Attached files: ${filePaths.map(getFileName).join(", ")}`;
+  const attachmentSummary = `${ATTACHMENT_SUMMARY_PREFIX}${filePaths.map(getFileName).join(", ")}`;
   return text.trim()
     ? `${text.trim()}\n\n${attachmentSummary}`
     : attachmentSummary;