fix(canvas): guard star/hide toggles against double-submit races

Two Greptile findings on the hide hook, both inherited from the star hook, so
fix them symmetrically:

- Ignore toggle re-clicks while a create/delete is in flight. The cache only
  updates on success, so a quick double-tap fired two creates for the same path,
  leaving a duplicate shortcut that a single later toggle couldn't clear.
- Swallow failures in the delete-on-channel-delete cleanup so a rejected request
  doesn't surface as an unhandled promise rejection.

Generated-By: PostHog Code
Task-Id: 4c16844c-acc9-4124-909d-f07335710a91

Author: mayteio

packages/ui/src/features/canvas/hooks/useChannelHides.ts

@@ -116,11 +116,16 @@ export function useChannelHideToggle(channel: Channel): {
   removeHidden: () => void;
 } {
   const { hiddenRefToShortcutId } = useChannelHides();
-  const { hide, unhide } = useChannelHideMutations();
+  const { hide, unhide, isHiding, isUnhiding } = useChannelHideMutations();
   const shortcutId = hiddenRefToShortcutId.get(channel.path);
   const isHidden = shortcutId !== undefined;
 
   const toggleHidden = useCallback(() => {
+    // Ignore re-clicks while a hide/unhide is in flight. The cache only updates
+    // once the request resolves, so without this guard a quick double-tap would
+    // fire two creates for the same path — leaving a duplicate marker that a
+    // single later unhide can't fully clear.
+    if (isHiding || isUnhiding) return;
     const run = shortcutId ? unhide(shortcutId) : hide(channel);
     run.catch((error: unknown) => {
       toast.error(
@@ -130,11 +135,13 @@ export function useChannelHideToggle(channel: Channel): {
         },
       );
     });
-  }, [channel, shortcutId, isHidden, hide, unhide]);
+  }, [channel, shortcutId, isHidden, hide, unhide, isHiding, isUnhiding]);
 
   const removeHidden = useCallback(() => {
     if (shortcutId) {
-      void unhide(shortcutId);
+      // Best-effort cleanup when the channel is deleted; swallow failures so a
+      // rejected delete doesn't surface as an unhandled rejection.
+      void unhide(shortcutId).catch(() => {});
     }
   }, [shortcutId, unhide]);
 

packages/ui/src/features/canvas/hooks/useChannelStars.ts

@@ -117,11 +117,16 @@ export function useChannelStarToggle(channel: Channel): {
   removeStar: () => void;
 } {
   const { starredRefToShortcutId } = useChannelStars();
-  const { star, unstar } = useChannelStarMutations();
+  const { star, unstar, isStarring, isUnstarring } = useChannelStarMutations();
   const shortcutId = starredRefToShortcutId.get(channel.path);
   const isStarred = shortcutId !== undefined;
 
   const toggleStar = useCallback(() => {
+    // Ignore re-clicks while a star/unstar is in flight. The cache only updates
+    // once the request resolves, so without this guard a quick double-tap would
+    // fire two creates for the same path — leaving a duplicate shortcut that a
+    // single later unstar can't fully clear.
+    if (isStarring || isUnstarring) return;
     const run = shortcutId ? unstar(shortcutId) : star(channel);
     run.catch((error: unknown) => {
       toast.error(
@@ -131,11 +136,13 @@ export function useChannelStarToggle(channel: Channel): {
         },
       );
     });
-  }, [channel, shortcutId, isStarred, star, unstar]);
+  }, [channel, shortcutId, isStarred, star, unstar, isStarring, isUnstarring]);
 
   const removeStar = useCallback(() => {
     if (shortcutId) {
-      void unstar(shortcutId);
+      // Best-effort cleanup when the channel is deleted; swallow failures so a
+      // rejected delete doesn't surface as an unhandled rejection.
+      void unstar(shortcutId).catch(() => {});
     }
   }, [shortcutId, unstar]);